diff options
author | Jim Wilson <jim.wilson@linaro.org> | 2016-12-21 12:33:12 -0800 |
---|---|---|
committer | Jim Wilson <jim.wilson@linaro.org> | 2016-12-21 12:33:12 -0800 |
commit | 87903eafb083abbf330c22fbf941fcbad700c098 (patch) | |
tree | 832a5f42fb2e2488edc7a47f8f9e23225e39c1a7 /sim/aarch64/simulator.c | |
parent | f0d19df99dfe1c63842206d15ae41dfd33d25bf0 (diff) | |
download | gdb-87903eafb083abbf330c22fbf941fcbad700c098.zip gdb-87903eafb083abbf330c22fbf941fcbad700c098.tar.gz gdb-87903eafb083abbf330c22fbf941fcbad700c098.tar.bz2 |
Fix bugs with float compare and Inf operands.
sim/aarch64/
* simulator.c (set_flags_for_float_compare): Add code to handle Inf.
Add comment to document NaN issue.
(set_flags_for_double_compare): Likewise.
sim/testsuite/sim/aarch64/
* fcmp.s: New.
Diffstat (limited to 'sim/aarch64/simulator.c')
-rw-r--r-- | sim/aarch64/simulator.c | 28 |
1 files changed, 28 insertions, 0 deletions
diff --git a/sim/aarch64/simulator.c b/sim/aarch64/simulator.c index e6406dc..be3d6c7 100644 --- a/sim/aarch64/simulator.c +++ b/sim/aarch64/simulator.c @@ -8468,8 +8468,22 @@ set_flags_for_float_compare (sim_cpu *cpu, float fvalue1, float fvalue2) { uint32_t flags; + /* FIXME: Add exception raising. */ if (isnan (fvalue1) || isnan (fvalue2)) flags = C|V; + else if (isinf (fvalue1) && isinf (fvalue2)) + { + /* Subtracting two infinities may give a NaN. We only need to compare + the signs, which we can get from isinf. */ + int result = isinf (fvalue1) - isinf (fvalue2); + + if (result == 0) + flags = Z|C; + else if (result < 0) + flags = N; + else /* (result > 0). */ + flags = C; + } else { float result = fvalue1 - fvalue2; @@ -8540,8 +8554,22 @@ set_flags_for_double_compare (sim_cpu *cpu, double dval1, double dval2) { uint32_t flags; + /* FIXME: Add exception raising. */ if (isnan (dval1) || isnan (dval2)) flags = C|V; + else if (isinf (dval1) && isinf (dval2)) + { + /* Subtracting two infinities may give a NaN. We only need to compare + the signs, which we can get from isinf. */ + int result = isinf (dval1) - isinf (dval2); + + if (result == 0) + flags = Z|C; + else if (result < 0) + flags = N; + else /* (result > 0). */ + flags = C; + } else { double result = dval1 - dval2; |