aboutsummaryrefslogtreecommitdiff
path: root/libsframe/sframe.c
diff options
context:
space:
mode:
authorStam Markianos-Wright <stam.markianos-wright@arm.com>2023-01-17 12:57:47 +0000
committerTamar Christina <tamar.christina@arm.com>2023-01-17 13:38:47 +0000
commit656412a7a4da0aef43ead1ea976ba0235a7ec30a (patch)
tree2e2263e55499e324660b0c4cd5e8d63d28a861f7 /libsframe/sframe.c
parent13023445a33e246aa3e221ed746935f5bcb0372d (diff)
downloadgdb-656412a7a4da0aef43ead1ea976ba0235a7ec30a.zip
gdb-656412a7a4da0aef43ead1ea976ba0235a7ec30a.tar.gz
gdb-656412a7a4da0aef43ead1ea976ba0235a7ec30a.tar.bz2
gas: arm: Fix a further IT-predicated vcvt issue in the presense of MVE vcvtn
Previously we had experienced issues with assembling a "VCVTNE" instruction in the presence of the MVE architecture extension, because it could be interpreted both as: * The base instruction VCVT + NE for IT predication when inside an IT block. * The MVE instruction VCVTN + E in the Else of a VPT block. Given a C reproducer of: ``` int test_function(float value) { int ret_val = 10; if (value != 0.0) { ret_val = (int) value; } return ret_val; } ``` GCC generates a VCVTNE instruction based on the `truncsisf2_vfp` pattern, which will look like: `vcvtne.s32.f32 s-reg, s-reg` This still triggers an error due to being misidentified as "vcvtn+e" Similar errors were found with other type combinations and instruction patterns (these have all been added to the testing of this patch). This class of errors was previously worked around by: https://sourceware.org/pipermail/binutils/2020-August/112728.html which addressed this by looking at the operand types, however, that isn't adequate to cover all the extra cases that have been found. Instead, we add some special-casing logic earlier when the instructions are parsed that is conditional on whether we are in a VPT block or not, when the instruction is parsed. gas/ChangeLog: * config/tc-arm.c (opcode_lookup): Add special vcvtn handling. * testsuite/gas/arm/mve-vcvtne-it-bad.l: Add further testing. * testsuite/gas/arm/mve-vcvtne-it-bad.s: Likewise. * testsuite/gas/arm/mve-vcvtne-it.d: Likewise. * testsuite/gas/arm/mve-vcvtne-it.s: Likewise.
Diffstat (limited to 'libsframe/sframe.c')
0 files changed, 0 insertions, 0 deletions