aboutsummaryrefslogtreecommitdiff
path: root/ld
diff options
context:
space:
mode:
authorAlan Modra <amodra@gmail.com>2020-07-10 10:48:45 +0930
committerAlan Modra <amodra@gmail.com>2020-07-10 11:14:38 +0930
commitd3b10ee787216d304a858246656ed2fdaecdfd93 (patch)
tree8a07c8d1aae6020bbf39bbc27fe4f7d309e95433 /ld
parentbf7682fdf7cf8e1efd361063e2a3a01eca953958 (diff)
downloadgdb-d3b10ee787216d304a858246656ed2fdaecdfd93.zip
gdb-d3b10ee787216d304a858246656ed2fdaecdfd93.tar.gz
gdb-d3b10ee787216d304a858246656ed2fdaecdfd93.tar.bz2
PowerPC64 ld --no-power10-stubs
Needed for libraries that use ifuncs or other means to support cpu-optimized versions of functions, some power10, some not, and those functions make calls using linkage stubs. bfd/ * elf64-ppc.h (struct ppc64_elf_params): Add power10_stubs. * elf64-ppc.c (struct ppc_link_hash_table): Delete power10_stubs. (ppc64_elf_check_relocs): Adjust setting of power10_stubs. (plt_stub_size, ppc_build_one_stub, ppc_size_one_stub): Adjust uses of power10_stubs. ld/ * emultempl/ppc64elf.em (params): Init new field. (enum ppc64_opt): Add OPTION_POWER10_STUBS and OPTION_NO_POWER10_STUBS. (PARSE_AND_LIST_LONGOPTS): Support --power10-stubs and --no-power10-stubs. (PARSE_AND_LIST_OPTIONS, PARSE_AND_LIST_ARGS_CASES): Likewise. * testsuite/ld-powerpc/callstub-3.d: New test. * testsuite/ld-powerpc/powerpc.exp: Run it.
Diffstat (limited to 'ld')
-rw-r--r--ld/ChangeLog10
-rw-r--r--ld/emultempl/ppc64elf.em20
-rw-r--r--ld/testsuite/ld-powerpc/callstub-3.d38
-rw-r--r--ld/testsuite/ld-powerpc/powerpc.exp1
4 files changed, 68 insertions, 1 deletions
diff --git a/ld/ChangeLog b/ld/ChangeLog
index 14f31a8..b9c844c 100644
--- a/ld/ChangeLog
+++ b/ld/ChangeLog
@@ -1,3 +1,13 @@
+2020-07-10 Alan Modra <amodra@gmail.com>
+
+ * emultempl/ppc64elf.em (params): Init new field.
+ (enum ppc64_opt): Add OPTION_POWER10_STUBS and OPTION_NO_POWER10_STUBS.
+ (PARSE_AND_LIST_LONGOPTS): Support --power10-stubs and
+ --no-power10-stubs.
+ (PARSE_AND_LIST_OPTIONS, PARSE_AND_LIST_ARGS_CASES): Likewise.
+ * testsuite/ld-powerpc/callstub-3.d: New test.
+ * testsuite/ld-powerpc/powerpc.exp: Run it.
+
2020-07-09 Alan Modra <amodra@gmail.com>
* emulparams/ppcpe.sh: Delete.
diff --git a/ld/emultempl/ppc64elf.em b/ld/emultempl/ppc64elf.em
index a2834c8..4987243 100644
--- a/ld/emultempl/ppc64elf.em
+++ b/ld/emultempl/ppc64elf.em
@@ -38,7 +38,7 @@ static struct ppc64_elf_params params = { NULL,
&ppc_layout_sections_again,
1, -1, -1, 0,
${DEFAULT_PLT_STATIC_CHAIN-0}, -1, 5,
- -1, 0, -1, -1, 0};
+ -1, -1, 0, -1, -1, 0};
/* Fake input file for stubs. */
static lang_input_statement_type *stub_file;
@@ -684,6 +684,8 @@ enum ppc64_opt
OPTION_NO_PLT_ALIGN,
OPTION_PLT_LOCALENTRY,
OPTION_NO_PLT_LOCALENTRY,
+ OPTION_POWER10_STUBS,
+ OPTION_NO_POWER10_STUBS,
OPTION_STUBSYMS,
OPTION_NO_STUBSYMS,
OPTION_SAVRES,
@@ -714,6 +716,8 @@ PARSE_AND_LIST_LONGOPTS=${PARSE_AND_LIST_LONGOPTS}'
{ "no-plt-align", no_argument, NULL, OPTION_NO_PLT_ALIGN },
{ "plt-localentry", optional_argument, NULL, OPTION_PLT_LOCALENTRY },
{ "no-plt-localentry", no_argument, NULL, OPTION_NO_PLT_LOCALENTRY },
+ { "power10-stubs", no_argument, NULL, OPTION_POWER10_STUBS },
+ { "no-power10-stubs", no_argument, NULL, OPTION_NO_POWER10_STUBS },
{ "emit-stub-syms", no_argument, NULL, OPTION_STUBSYMS },
{ "no-emit-stub-syms", no_argument, NULL, OPTION_NO_STUBSYMS },
{ "dotsyms", no_argument, NULL, OPTION_DOTSYMS },
@@ -769,6 +773,12 @@ PARSE_AND_LIST_OPTIONS=${PARSE_AND_LIST_OPTIONS}'
--no-plt-localentry Don'\''t optimize ELFv2 calls\n"
));
fprintf (file, _("\
+ --power10-stubs Use Power10 PLT call stubs (default auto)\n"
+ ));
+ fprintf (file, _("\
+ --no-power10-stubs Don'\''t use Power10 PLT call stubs\n"
+ ));
+ fprintf (file, _("\
--emit-stub-syms Label linker stubs with a symbol\n"
));
fprintf (file, _("\
@@ -878,6 +888,14 @@ PARSE_AND_LIST_ARGS_CASES=${PARSE_AND_LIST_ARGS_CASES}'
params.plt_localentry0 = 0;
break;
+ case OPTION_POWER10_STUBS:
+ params.power10_stubs = 1;
+ break;
+
+ case OPTION_NO_POWER10_STUBS:
+ params.power10_stubs = 0;
+ break;
+
case OPTION_STUBSYMS:
params.emit_stub_syms = 1;
break;
diff --git a/ld/testsuite/ld-powerpc/callstub-3.d b/ld/testsuite/ld-powerpc/callstub-3.d
new file mode 100644
index 0000000..06cbfbd
--- /dev/null
+++ b/ld/testsuite/ld-powerpc/callstub-3.d
@@ -0,0 +1,38 @@
+#source: callstub-1.s
+#as: -a64 -mpower10
+#ld: -melf64ppc -shared --plt-align=0 --hash-style=gnu --no-power10-stubs
+#objdump: -dr -Mpower10
+
+.*
+
+Disassembly of section \.text:
+
+.*\.plt_call\.f1>:
+.*: (f8 41 00 18|18 00 41 f8) std r2,24\(r1\)
+.*: (7d 88 02 a6|a6 02 88 7d) mflr r12
+.*: (42 9f 00 05|05 00 9f 42) bcl .*
+.*: (7d 68 02 a6|a6 02 68 7d) mflr r11
+.*: (7d 88 03 a6|a6 03 88 7d) mtlr r12
+.*: (3d 8b 00 01|01 00 8b 3d) addis r12,r11,1
+.*: (e9 8c .. ..|.. .. 8c e9) ld r12,.*\(r12\)
+.*: (7d 89 03 a6|a6 03 89 7d) mtctr r12
+.*: (4e 80 04 20|20 04 80 4e) bctr
+
+.*\.plt_call\.f2>:
+.*: (7d 88 02 a6|a6 02 88 7d) mflr r12
+.*: (42 9f 00 05|05 00 9f 42) bcl .*
+.*: (7d 68 02 a6|a6 02 68 7d) mflr r11
+.*: (7d 88 03 a6|a6 03 88 7d) mtlr r12
+.*: (3d 8b 00 01|01 00 8b 3d) addis r12,r11,1
+.*: (e9 8c .. ..|.. .. 8c e9) ld r12,.*\(r12\)
+.*: (7d 89 03 a6|a6 03 89 7d) mtctr r12
+.*: (4e 80 04 20|20 04 80 4e) bctr
+
+#...
+.*: (4b ff ff 81|81 ff ff 4b) bl .*\.plt_call\.f1>
+.*: (e8 41 00 18|18 00 41 e8) ld r2,24\(r1\)
+.*: (4b ff ff 7d|7d ff ff 4b) bl .*\.plt_call\.f1\+0x4>
+.*: (4b ff ff 99|99 ff ff 4b) bl .*\.plt_call\.f2>
+.*: (04 10 00 01|01 00 10 04) pld r3,.*
+.*: (e4 60 .. ..|.. .. 60 e4)
+#pass
diff --git a/ld/testsuite/ld-powerpc/powerpc.exp b/ld/testsuite/ld-powerpc/powerpc.exp
index de676b8..50553ba 100644
--- a/ld/testsuite/ld-powerpc/powerpc.exp
+++ b/ld/testsuite/ld-powerpc/powerpc.exp
@@ -402,6 +402,7 @@ if [ supports_ppc64 ] then {
run_dump_test "pr23937"
run_dump_test "callstub-1"
run_dump_test "callstub-2"
+ run_dump_test "callstub-3"
run_dump_test "tlsgd"
run_dump_test "tlsld"
run_dump_test "tlsie"