aboutsummaryrefslogtreecommitdiff
path: root/ld
diff options
context:
space:
mode:
authorH.J. Lu <hjl.tools@gmail.com>2022-05-31 15:38:19 -0700
committerH.J. Lu <hjl.tools@gmail.com>2022-05-31 16:28:06 -0700
commit98a1627f19ca125476d5d58d9999c7a8d381f403 (patch)
tree8b914cd61a73e4408c126ce876999768c96ce469 /ld
parentb8be9aea5c62124373c739234fc36d7d85ab4dc4 (diff)
downloadgdb-98a1627f19ca125476d5d58d9999c7a8d381f403.zip
gdb-98a1627f19ca125476d5d58d9999c7a8d381f403.tar.gz
gdb-98a1627f19ca125476d5d58d9999c7a8d381f403.tar.bz2
x86: Properly handle IFUNC function pointer reference
Update commit 68c4956b1401de70173848a6bdf620cb42fa9358 Author: H.J. Lu <hjl.tools@gmail.com> Date: Tue Apr 26 09:08:54 2022 -0700 x86: Properly handle function pointer reference to properly handle IFUNC function pointer reference. Since IFUNC symbol value is only known at run-time, set pointer_equality_needed for IFUNC function pointer reference in PDE so that it will be resolved to its PLT entry directly. bfd/ PR ld/29216 * elf32-i386.c (elf_i386_scan_relocs): Set pointer_equality_needed for IFUNC function pointer reference in PDE. * elf64-x86-64.c (elf_x86_64_scan_relocs): Likewise. ld/ PR ld/29216 * testsuite/ld-ifunc/ifunc.exp: Run PR ld/29216 test. * testsuite/ld-ifunc/pr29216.c: New file.
Diffstat (limited to 'ld')
-rw-r--r--ld/testsuite/ld-ifunc/ifunc.exp9
-rw-r--r--ld/testsuite/ld-ifunc/pr29216.c62
2 files changed, 71 insertions, 0 deletions
diff --git a/ld/testsuite/ld-ifunc/ifunc.exp b/ld/testsuite/ld-ifunc/ifunc.exp
index 1cd8d38..fdb65d0 100644
--- a/ld/testsuite/ld-ifunc/ifunc.exp
+++ b/ld/testsuite/ld-ifunc/ifunc.exp
@@ -714,6 +714,15 @@ run_ld_link_exec_tests [list \
"pr18841cn" \
"pr18841.out" \
] \
+ [list \
+ "Run pr29216" \
+ "$NOPIE_LDFLAGS" \
+ "" \
+ { pr29216.c } \
+ "pr29216" \
+ "pass.out" \
+ "-fPIC" \
+ ] \
]
# The pr23169 testcase is not valid. In general, you can't call ifunc
diff --git a/ld/testsuite/ld-ifunc/pr29216.c b/ld/testsuite/ld-ifunc/pr29216.c
new file mode 100644
index 0000000..5019c72
--- /dev/null
+++ b/ld/testsuite/ld-ifunc/pr29216.c
@@ -0,0 +1,62 @@
+#include <stdio.h>
+
+static int
+one (void)
+{
+ return -30;
+}
+
+int foo (void) __attribute__ ((ifunc ("resolve_foo")));
+
+void *
+resolve_foo (void)
+{
+ return (void *) one;
+}
+
+typedef int (*foo_p) (void);
+
+foo_p foo_ptr = foo;
+
+foo_p
+__attribute__ ((noinline))
+get_foo_p (void)
+{
+ return foo_ptr;
+}
+
+foo_p
+__attribute__ ((noinline))
+get_foo (void)
+{
+ return foo;
+}
+
+int
+main (void)
+{
+ foo_p p;
+
+ p = get_foo ();
+ if (p != foo)
+ __builtin_abort ();
+ if ((*p) () != -30)
+ __builtin_abort ();
+
+ p = get_foo_p ();
+ if (p != foo)
+ __builtin_abort ();
+ if ((*p) () != -30)
+ __builtin_abort ();
+
+ if (foo_ptr != foo)
+ __builtin_abort ();
+ if ((*foo_ptr) () != -30)
+ __builtin_abort ();
+ if (foo () != -30)
+ __builtin_abort ();
+
+ printf ("PASS\n");
+
+ return 0;
+}