aboutsummaryrefslogtreecommitdiff
path: root/ld
diff options
context:
space:
mode:
authorAlan Modra <amodra@gmail.com>2018-02-20 19:32:12 +1030
committerAlan Modra <amodra@gmail.com>2018-02-26 09:29:15 +1030
commit9793eb77929a4ab2c0192d9bf5d3f8d20dd17394 (patch)
tree88e647f8bab10d99c15aa582caca27468306ba6b /ld
parent0aa13feeeb78fc9323bee329c4d91c30f25de121 (diff)
downloadgdb-9793eb77929a4ab2c0192d9bf5d3f8d20dd17394.zip
gdb-9793eb77929a4ab2c0192d9bf5d3f8d20dd17394.tar.gz
gdb-9793eb77929a4ab2c0192d9bf5d3f8d20dd17394.tar.bz2
ELF linker messages
This fixes a number of cases where we capitalized error messages or printed a full-stop, and corrects "Dwarf" to "DWARF". bfd/ * dwarf2.c, * elf-attrs.c, * elf-eh-frame.c, * elf.c, * elf32-gen.c, * elflink.c: Standardize error/warning messages. Replace use of linker callback einfo with _bfd_error_handler when possible. ld/ * testsuite/ld-elf/indirect.exp, * testsuite/ld-elf/pr22649-2ab-mips.msg, * testsuite/ld-elf/pr22649-2cd-mips.msg, * testsuite/ld-elf/pr22649.msg, * testsuite/ld-elf/tls_common.exp, * testsuite/ld-elfcomm/elfcomm.exp, * testsuite/ld-arm/attr-merge-incompatible.d, * testsuite/ld-tic6x/attr-compatibility-gnu-other.d, * testsuite/ld-tic6x/attr-compatibility-other-gnu.d, * testsuite/ld-tic6x/attr-compatibility-other-other.d, * testsuite/ld-i386/warn1.d: Update expected error/warning messages.
Diffstat (limited to 'ld')
-rw-r--r--ld/ChangeLog14
-rw-r--r--ld/testsuite/ld-arm/attr-merge-incompatible.d2
-rw-r--r--ld/testsuite/ld-elf/indirect.exp2
-rw-r--r--ld/testsuite/ld-elf/pr22649-2ab-mips.msg4
-rw-r--r--ld/testsuite/ld-elf/pr22649-2cd-mips.msg2
-rw-r--r--ld/testsuite/ld-elf/pr22649.msg2
-rw-r--r--ld/testsuite/ld-elf/tls_common.exp4
-rw-r--r--ld/testsuite/ld-elfcomm/elfcomm.exp8
-rw-r--r--ld/testsuite/ld-i386/warn1.d2
-rw-r--r--ld/testsuite/ld-tic6x/attr-compatibility-gnu-other.d2
-rw-r--r--ld/testsuite/ld-tic6x/attr-compatibility-other-gnu.d2
-rw-r--r--ld/testsuite/ld-tic6x/attr-compatibility-other-other.d2
12 files changed, 30 insertions, 16 deletions
diff --git a/ld/ChangeLog b/ld/ChangeLog
index 8eeaf41..170173d 100644
--- a/ld/ChangeLog
+++ b/ld/ChangeLog
@@ -1,5 +1,19 @@
2018-02-26 Alan Modra <amodra@gmail.com>
+ * testsuite/ld-elf/indirect.exp,
+ * testsuite/ld-elf/pr22649-2ab-mips.msg,
+ * testsuite/ld-elf/pr22649-2cd-mips.msg,
+ * testsuite/ld-elf/pr22649.msg,
+ * testsuite/ld-elf/tls_common.exp,
+ * testsuite/ld-elfcomm/elfcomm.exp,
+ * testsuite/ld-arm/attr-merge-incompatible.d,
+ * testsuite/ld-tic6x/attr-compatibility-gnu-other.d,
+ * testsuite/ld-tic6x/attr-compatibility-other-gnu.d,
+ * testsuite/ld-tic6x/attr-compatibility-other-other.d,
+ * testsuite/ld-i386/warn1.d: Update expected error/warning messages.
+
+2018-02-26 Alan Modra <amodra@gmail.com>
+
* testsuite/ld-powerpc/attr-gnu-12-21.d,
* testsuite/ld-powerpc/attr-gnu-4-12.d,
* testsuite/ld-powerpc/attr-gnu-4-13.d,
diff --git a/ld/testsuite/ld-arm/attr-merge-incompatible.d b/ld/testsuite/ld-arm/attr-merge-incompatible.d
index 41711da..74cf90c 100644
--- a/ld/testsuite/ld-arm/attr-merge-incompatible.d
+++ b/ld/testsuite/ld-arm/attr-merge-incompatible.d
@@ -2,4 +2,4 @@
#source: attr-merge-incompatiblea.s
#as:
#ld:
-#error: Object has vendor-specific contents that must be processed by the '.+' toolchain
+#error: object has vendor-specific contents that must be processed by the '.+' toolchain
diff --git a/ld/testsuite/ld-elf/indirect.exp b/ld/testsuite/ld-elf/indirect.exp
index 9fa2bac..71664e7 100644
--- a/ld/testsuite/ld-elf/indirect.exp
+++ b/ld/testsuite/ld-elf/indirect.exp
@@ -124,7 +124,7 @@ set cmd "$ld -e start -o tmpdir/indirect1 tmpdir/indirect1a.o tmpdir/libindirect
check_link_message "$cmd" [list $string1 $string] "$testname"
set string ": final link failed: Nonrepresentable section on output"
-set string2 ": No symbol version section for versioned symbol \`foo@FOO\'"
+set string2 ": no symbol version section for versioned symbol \`foo@FOO\'"
set testname "Indirect symbol 2"
set cmd "$ld -shared -o tmpdir/indirect2.so tmpdir/indirect2.o"
check_link_message "$cmd" [list $string2 $string] "$testname"
diff --git a/ld/testsuite/ld-elf/pr22649-2ab-mips.msg b/ld/testsuite/ld-elf/pr22649-2ab-mips.msg
index e27e6e4..e819cc0 100644
--- a/ld/testsuite/ld-elf/pr22649-2ab-mips.msg
+++ b/ld/testsuite/ld-elf/pr22649-2ab-mips.msg
@@ -1,2 +1,2 @@
-.*: Removing unused section '\.data' in file 'tmpdir/pr22649-2.\.o'
-.*: Removing unused section '\.(?:reginfo|MIPS\.options)' in file 'tmpdir/pr22649-2.\.o'
+.*: removing unused section '\.data' in file 'tmpdir/pr22649-2.\.o'
+.*: removing unused section '\.(?:reginfo|MIPS\.options)' in file 'tmpdir/pr22649-2.\.o'
diff --git a/ld/testsuite/ld-elf/pr22649-2cd-mips.msg b/ld/testsuite/ld-elf/pr22649-2cd-mips.msg
index 6a7aa77..a513d82 100644
--- a/ld/testsuite/ld-elf/pr22649-2cd-mips.msg
+++ b/ld/testsuite/ld-elf/pr22649-2cd-mips.msg
@@ -1 +1 @@
-.*: Removing unused section '\.(?:reginfo|MIPS\.options)' in file 'tmpdir/pr22649-2.\.o'
+.*: removing unused section '\.(?:reginfo|MIPS\.options)' in file 'tmpdir/pr22649-2.\.o'
diff --git a/ld/testsuite/ld-elf/pr22649.msg b/ld/testsuite/ld-elf/pr22649.msg
index 66b5f25..76d64a4 100644
--- a/ld/testsuite/ld-elf/pr22649.msg
+++ b/ld/testsuite/ld-elf/pr22649.msg
@@ -1,3 +1,3 @@
#...
-.*: Removing unused section '\.data' in file 'tmpdir/pr22649-2.*\.o'
+.*: removing unused section '\.data' in file 'tmpdir/pr22649-2.*\.o'
#pass
diff --git a/ld/testsuite/ld-elf/tls_common.exp b/ld/testsuite/ld-elf/tls_common.exp
index 80b0efa..ce3ec90 100644
--- a/ld/testsuite/ld-elf/tls_common.exp
+++ b/ld/testsuite/ld-elf/tls_common.exp
@@ -57,7 +57,7 @@ if { ![ld_link $ld tmpdir/tls_commona "tmpdir/tls_common1a.o"] } {
if { [string match "*not supported*" $link_output]
|| [string match "*unrecognized option*" $link_output] } {
unsupported "$ld_options is not supported by this target"
- } elseif { [string match "*Warning*alignment*of common symbol*" $link_output] } {
+ } elseif { [string match "*warning*alignment*of common symbol*" $link_output] } {
fail "tls_common"
} else {
unresolved "tls_common"
@@ -69,7 +69,7 @@ if { ![ld_link $ld tmpdir/tls_commonb "tmpdir/tls_common1b.o"] } {
if { [string match "*not supported*" $link_output]
|| [string match "*unrecognized option*" $link_output] } {
unsupported "$ld_options is not supported by this target"
- } elseif { [string match "*Warning*alignment*of common symbol*" $link_output] } {
+ } elseif { [string match "*warning*alignment*of common symbol*" $link_output] } {
fail "tls_common"
} else {
unresolved "tls_common"
diff --git a/ld/testsuite/ld-elfcomm/elfcomm.exp b/ld/testsuite/ld-elfcomm/elfcomm.exp
index 4f3ebdd..7aafd82 100644
--- a/ld/testsuite/ld-elfcomm/elfcomm.exp
+++ b/ld/testsuite/ld-elfcomm/elfcomm.exp
@@ -199,14 +199,14 @@ if { [ld_link $ld tmpdir/common1.o $options] } {
# This test fails on MIPS because the backend sets type_change_ok.
# The size change warning is suppressed. Same on hppa64.
if {[istarget mips*-*-*] || [istarget hppa*64*-*-*]} {
- if { ![regexp "Warning: alignment (\[0-9\]+) of symbol \`_?foo1\' in tmpdir/common1b.o is smaller than 64 in tmpdir/common1a.o" $link_output] } {
+ if { ![regexp "warning: alignment (\[0-9\]+) of symbol \`_?foo1\' in tmpdir/common1b.o is smaller than 64 in tmpdir/common1a.o" $link_output] } {
fail $test1w1
} else {
pass $test1w1
}
} else {
- if { ![regexp "Warning: alignment (\[0-9\]+) of symbol \`_?foo1\' in tmpdir/common1b.o is smaller than 64 in tmpdir/common1a.o" $link_output]
- || ![regexp "Warning: size of symbol \`_?foo1\' changed from 2 in tmpdir/common1a.o to 21 in tmpdir/common1b.o" $link_output] } {
+ if { ![regexp "warning: alignment (\[0-9\]+) of symbol \`_?foo1\' in tmpdir/common1b.o is smaller than 64 in tmpdir/common1a.o" $link_output]
+ || ![regexp "warning: size of symbol \`_?foo1\' changed from 2 in tmpdir/common1a.o to 21 in tmpdir/common1b.o" $link_output] } {
fail $test1w1
} else {
pass $test1w1
@@ -233,7 +233,7 @@ if { [ld_link $ld tmpdir/common1.o $options] } {
return
}
-if { ![regexp "Warning: alignment (\[0-9\]+) of symbol \`_?foo1\' in tmpdir/common1b.o is smaller than 64 in tmpdir/common1a.o" $link_output] } {
+if { ![regexp "warning: alignment (\[0-9\]+) of symbol \`_?foo1\' in tmpdir/common1b.o is smaller than 64 in tmpdir/common1a.o" $link_output] } {
fail $test1w2
} else {
pass $test1w2
diff --git a/ld/testsuite/ld-i386/warn1.d b/ld/testsuite/ld-i386/warn1.d
index dd541f2..3c78f31 100644
--- a/ld/testsuite/ld-i386/warn1.d
+++ b/ld/testsuite/ld-i386/warn1.d
@@ -1,4 +1,4 @@
#name: --warn-shared-textrel --fatal-warnings
#as: --32
#ld: -shared -melf_i386 --warn-shared-textrel --fatal-warnings
-#error: .*warning: creating a DT_TEXTREL in a shared object.
+#error: .*warning: creating a DT_TEXTREL in a shared object
diff --git a/ld/testsuite/ld-tic6x/attr-compatibility-gnu-other.d b/ld/testsuite/ld-tic6x/attr-compatibility-gnu-other.d
index 423ab07..e232314 100644
--- a/ld/testsuite/ld-tic6x/attr-compatibility-gnu-other.d
+++ b/ld/testsuite/ld-tic6x/attr-compatibility-gnu-other.d
@@ -3,4 +3,4 @@
#ld: -r -melf32_tic6x_le
#source: attr-compatibility-gnu.s
#source: attr-compatibility-other.s
-#error: .*Object has vendor-specific contents that must be processed by the 'other' toolchain
+#error: .*object has vendor-specific contents that must be processed by the 'other' toolchain
diff --git a/ld/testsuite/ld-tic6x/attr-compatibility-other-gnu.d b/ld/testsuite/ld-tic6x/attr-compatibility-other-gnu.d
index 80d73e5..d60dd90 100644
--- a/ld/testsuite/ld-tic6x/attr-compatibility-other-gnu.d
+++ b/ld/testsuite/ld-tic6x/attr-compatibility-other-gnu.d
@@ -3,4 +3,4 @@
#ld: -r -melf32_tic6x_le
#source: attr-compatibility-other.s
#source: attr-compatibility-gnu.s
-#error: .*Object tag '1, gnu' is incompatible with tag '1, other'
+#error: .*object tag '1, gnu' is incompatible with tag '1, other'
diff --git a/ld/testsuite/ld-tic6x/attr-compatibility-other-other.d b/ld/testsuite/ld-tic6x/attr-compatibility-other-other.d
index 0ebd99b..f1a5a20 100644
--- a/ld/testsuite/ld-tic6x/attr-compatibility-other-other.d
+++ b/ld/testsuite/ld-tic6x/attr-compatibility-other-other.d
@@ -3,4 +3,4 @@
#ld: -r -melf32_tic6x_le
#source: attr-compatibility-other.s
#source: attr-compatibility-other.s
-#error: .*Object has vendor-specific contents that must be processed by the 'other' toolchain
+#error: .*object has vendor-specific contents that must be processed by the 'other' toolchain