aboutsummaryrefslogtreecommitdiff
path: root/ld
diff options
context:
space:
mode:
authorPalmer Dabbelt <palmer@dabbelt.com>2016-12-29 17:29:53 -0800
committerPalmer Dabbelt <palmer@dabbelt.com>2017-01-09 09:12:20 -0800
commit6ec11ab97ab47ec4a22118e5b1c77df567796002 (patch)
tree406b8b88e75cbea56b9ea095f62ef44c029ef4d2 /ld
parentcd6581da62c32a391f9a4c2c5d248a11aa6fa8f7 (diff)
downloadgdb-6ec11ab97ab47ec4a22118e5b1c77df567796002.zip
gdb-6ec11ab97ab47ec4a22118e5b1c77df567796002.tar.gz
gdb-6ec11ab97ab47ec4a22118e5b1c77df567796002.tar.bz2
Remove some custom sections from RISC-V's default linker scripts
This was added so compressed loads could have smaller offsets for accessing the data section, but the result was that writable sections ended up in INITIAL_READONLY_SECTIONS. This is a bad idea. The fix is to just remove this micro-optimization. Thanks to Alan Morda for finding the problem! ld/ChangeLog 2017-01-09 Palmer Dabbelt <palmer@dabbelt.com> Kito Cheng <kito.cheng@gmail.com> * emulparams/elf32lriscv-defs.sh (INITIAL_READONLY_SECTIONS): Removed. (SDATA_START_SYMBOLS): Likewise.
Diffstat (limited to 'ld')
-rw-r--r--ld/emulparams/elf32lriscv-defs.sh12
1 files changed, 0 insertions, 12 deletions
diff --git a/ld/emulparams/elf32lriscv-defs.sh b/ld/emulparams/elf32lriscv-defs.sh
index 0e4b723..0eba0d1 100644
--- a/ld/emulparams/elf32lriscv-defs.sh
+++ b/ld/emulparams/elf32lriscv-defs.sh
@@ -26,17 +26,5 @@ COMMONPAGESIZE="CONSTANT (COMMONPAGESIZE)"
SDATA_START_SYMBOLS="_gp = . + 0x800;
*(.srodata.cst16) *(.srodata.cst8) *(.srodata.cst4) *(.srodata.cst2) *(.srodata .srodata.*)"
-# Place the data section before text section. This enables more compact
-# global variable access for RVC code via linker relaxation.
-INITIAL_READONLY_SECTIONS="
- .data : { *(.data) *(.data.*) *(.gnu.linkonce.d.*) }
- .rodata : { *(.rodata) *(.rodata.*) *(.gnu.linkonce.r.*) }
- .srodata : { ${SDATA_START_SYMBOLS} }
- .sdata : { *(.sdata .sdata.* .gnu.linkonce.s.*) }
- .sbss : { *(.dynsbss) *(.sbss .sbss.* .gnu.linkonce.sb.*) }
- .bss : { *(.dynbss) *(.bss .bss.* .gnu.linkonce.b.*) *(COMMON) }
- . = ALIGN(${SEGMENT_SIZE}) + (. & (${MAXPAGESIZE} - 1));"
INITIAL_READONLY_SECTIONS=".interp : { *(.interp) } ${CREATE_PIE-${INITIAL_READONLY_SECTIONS}}"
INITIAL_READONLY_SECTIONS="${RELOCATING+${CREATE_SHLIB-${INITIAL_READONLY_SECTIONS}}}"
-
-SDATA_START_SYMBOLS="${CREATE_PIE+${SDATA_START_SYMBOLS}}"