diff options
| author | H.J. Lu <hjl.tools@gmail.com> | 2018-07-20 09:18:47 -0700 |
|---|---|---|
| committer | H.J. Lu <hjl.tools@gmail.com> | 2018-07-20 09:19:00 -0700 |
| commit | 241e64e3b42cd9eba514b8e0ad2ef39a337f10a5 (patch) | |
| tree | d62e37adef725407d44dd34d778ddda4c20a60cb /ld/testsuite/lib | |
| parent | cbb09508e4b515501273288aaa11a8ef5e15e0ff (diff) | |
| download | gdb-241e64e3b42cd9eba514b8e0ad2ef39a337f10a5.zip gdb-241e64e3b42cd9eba514b8e0ad2ef39a337f10a5.tar.gz gdb-241e64e3b42cd9eba514b8e0ad2ef39a337f10a5.tar.bz2 | |
x86: Add a GNU_PROPERTY_X86_ISA_1_USED note if needed
When -z separate-code, which is enabled by default for Linux/x86, is
used to create executable, ld won't place any data in the code-only
PT_LOAD segment. If there are no data sections placed before the
code-only PT_LOAD segment, the program headers won't be mapped into
any PT_LOAD segment. When the executable tries to access it (based
on the program header address passed in AT_PHDR), it will lead to
segfault. This patch inserts a GNU_PROPERTY_X86_ISA_1_USED note if
there may be no data sections before the text section so that the
first PT_LOAD segment won't be code-only and will contain the program
header.
Testcases are adjusted to either pass "-z noseparate-code" to ld or
discard the .note.gnu.property section. A Linux/x86 run-time test is
added.
bfd/
PR ld/23428
* elfxx-x86.c (_bfd_x86_elf_link_setup_gnu_properties): If the
separate code program header is needed, make sure that the first
read-only PT_LOAD segment has no code by adding a
GNU_PROPERTY_X86_ISA_1_USED note.
ld/
PR ld/23428
* testsuite/ld-elf/linux-x86.S: New file.
* testsuite/ld-elf/linux-x86.exp: Likewise.
* testsuite/ld-elf/pr23428.c: Likewise.
* testsuite/ld-elf/sec64k.exp: Pass "-z noseparate-code" to ld
for Linux/x86 targets.
* testsuite/ld-i386/abs-iamcu.d: Likewise.
* testsuite/ld-i386/abs.d: Likewise.
* testsuite/ld-i386/pr12718.d: Likewise.
* testsuite/ld-i386/pr12921.d: Likewise.
* testsuite/ld-x86-64/abs-k1om.d: Likewise.
* testsuite/ld-x86-64/abs-l1om.d: Likewise.
* testsuite/ld-x86-64/abs.d: Likewise.
* testsuite/ld-x86-64/pr12718.d: Likewise.
* testsuite/ld-x86-64/pr12921.d: Likewise.
* testsuite/ld-linkonce/zeroeh.ld: Discard .note.gnu.property
section.
* testsuite/ld-scripts/print-memory-usage.t: Likewise.
* testsuite/ld-scripts/size-2.t: Likewise.
* testsuite/lib/ld-lib.exp (run_ld_link_exec_tests): Use ld
to create executable if language is "asm".
Diffstat (limited to 'ld/testsuite/lib')
| -rw-r--r-- | ld/testsuite/lib/ld-lib.exp | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/ld/testsuite/lib/ld-lib.exp b/ld/testsuite/lib/ld-lib.exp index 5880c67..2e7d368 100644 --- a/ld/testsuite/lib/ld-lib.exp +++ b/ld/testsuite/lib/ld-lib.exp @@ -1523,7 +1523,10 @@ proc run_ld_link_exec_tests { ldtests args } { continue } - if { [ string match "c++" $lang ] } { + if { [ string match "asm" $lang ] } { + set link_proc ld_link + set link_cmd $ld + } elseif { [ string match "c++" $lang ] } { set link_proc ld_link set link_cmd $CXX } else { |