diff options
author | H.J. Lu <hjl.tools@gmail.com> | 2020-06-09 06:56:55 -0700 |
---|---|---|
committer | H.J. Lu <hjl.tools@gmail.com> | 2020-06-09 06:57:25 -0700 |
commit | cebd6b8ac1c5a2a847a50e3efe932ff2d0867b3e (patch) | |
tree | 8b9a433e79396def968ebecb12f593ecc9fc124b /ld/testsuite/ld-x86-64/ifunc-textrel-2.s | |
parent | f9630fa654d3421698bccd95a68712af0c86a081 (diff) | |
download | gdb-cebd6b8ac1c5a2a847a50e3efe932ff2d0867b3e.zip gdb-cebd6b8ac1c5a2a847a50e3efe932ff2d0867b3e.tar.gz gdb-cebd6b8ac1c5a2a847a50e3efe932ff2d0867b3e.tar.bz2 |
IFUNC: Update IFUNC resolver check with DT_TEXTREL
Add ifunc_resolvers to elf_link_hash_table and use it for both x86 and
ppc64. Before glibc commit b5c45e837, DT_TEXTREL is incompatible with
IFUNC resolvers. Set ifunc_resolvers if there are IFUNC resolvers and
issue a warning for IFUNC resolvers with DT_TEXTREL.
bfd/
PR ld/18801
* elf-bfd.h (elf_link_hash_table): Add ifunc_resolvers.
(_bfd_elf_allocate_ifunc_dyn_relocs): Remove the
bfd_boolean * argument. Set ifunc_resolvers if there are IFUNC
resolvers.
* elf-ifunc.c (_bfd_elf_allocate_ifunc_dyn_relocs): Updated.
Set ifunc_resolvers if there are FUNC resolvers.
* elf64-ppc.c (ppc_link_hash_table): Remove local_ifunc_resolver.
(build_global_entry_stubs_and_plt): Replace local_ifunc_resolver
with elf.ifunc_resolvers.
(write_plt_relocs_for_local_syms): Likewise.
(ppc64_elf_relocate_section): Likewise.
(ppc64_elf_finish_dynamic_sections): Likewise.
* elfnn-aarch64.c (elfNN_aarch64_allocate_ifunc_dynrelocs):
Updated.
* elfxx-x86.c (elf_x86_allocate_dynrelocs): Likewise.
(_bfd_x86_elf_size_dynamic_sections): Check elf.ifunc_resolvers
instead of readonly_dynrelocs_against_ifunc.
* elfxx-x86.h (elf_x86_link_hash_table): Remove
readonly_dynrelocs_against_ifunc.
ld/
PR ld/18801
* testsuite/ld-i386/i386.exp: Run ifunc-textrel-1a,
ifunc-textrel-1b, ifunc-textrel-2a and ifunc-textrel-2b.
* testsuite/ld-x86-64/x86-64.exp: Likewise.
* testsuite/ld-i386/ifunc-textrel-1a.d: Likewise.
* testsuite/ld-i386/ifunc-textrel-1b.d: Likewise.
* testsuite/ld-i386/ifunc-textrel-2a.d: Likewise.
* testsuite/ld-i386/ifunc-textrel-2b.d: Likewise.
* testsuite/ld-x86-64/ifunc-textrel-1.s: Likewise.
* testsuite/ld-x86-64/ifunc-textrel-1a.d: Likewise.
* testsuite/ld-x86-64/ifunc-textrel-1b.d: Likewise.
* testsuite/ld-x86-64/ifunc-textrel-2.s: Likewise.
* testsuite/ld-x86-64/ifunc-textrel-2a.d: Likewise.
* testsuite/ld-x86-64/ifunc-textrel-2b.d: Likewise.
* testsuite/ld-i386/pr18801a.d: Expect warning for IFUNC
resolvers.
* testsuite/ld-i386/pr18801b.d: Likewise.
* estsuite/ld-x86-64/pr18801a.d: Likewise.
* estsuite/ld-x86-64/pr18801b.d: Likewise.
Diffstat (limited to 'ld/testsuite/ld-x86-64/ifunc-textrel-2.s')
-rw-r--r-- | ld/testsuite/ld-x86-64/ifunc-textrel-2.s | 28 |
1 files changed, 28 insertions, 0 deletions
diff --git a/ld/testsuite/ld-x86-64/ifunc-textrel-2.s b/ld/testsuite/ld-x86-64/ifunc-textrel-2.s new file mode 100644 index 0000000..5c8f271 --- /dev/null +++ b/ld/testsuite/ld-x86-64/ifunc-textrel-2.s @@ -0,0 +1,28 @@ + .text + .type selector, %function +foo: + movl $0, %eax + ret +selector: +.ifdef __x86_64__ + leaq foo(%rip), %rax +.else + leal foo@GOTOFF(%eax), %eax +.endif + ret + .type selector, %gnu_indirect_function + .globl _start +_start: +.ifdef __x86_64__ + movabs ptr, %rax + call *%rax +.else + mov ptr, %eax + call *%eax +.endif + ret + .data + .type ptr, @object +ptr: + .dc.a foo + .section .note.GNU-stack,"",@progbits |