diff options
| author | Andrew Burgess <aburgess@redhat.com> | 2022-09-02 18:15:30 +0100 |
|---|---|---|
| committer | Andrew Burgess <aburgess@redhat.com> | 2022-11-01 09:32:13 +0000 |
| commit | 8cb6e17571f3fb66ccd4fa19f881602542cd06fc (patch) | |
| tree | e55c7d09de4ee64ed49f0c9b8b345b2f666ce0de /ld/testsuite/ld-arm/tls-gdierelax.d | |
| parent | 1751ca43fdae8d19e13ae55430700a60eb0f30d3 (diff) | |
| download | gdb-8cb6e17571f3fb66ccd4fa19f881602542cd06fc.zip gdb-8cb6e17571f3fb66ccd4fa19f881602542cd06fc.tar.gz gdb-8cb6e17571f3fb66ccd4fa19f881602542cd06fc.tar.bz2 | |
opcodes/arm: use '@' consistently for the comment character
Looking at the ARM disassembler output, every comment seems to start
with a ';' character, so I assumed this was the correct character to
start an assembler comment.
I then spotted a couple of places where there was no ';', but instead,
just a '@' character. I thought that this was a case of a missing
';', and proposed a patch to add the missing ';' characters.
Turns out I was wrong, '@' is actually the ARM assembler comment
character, while ';' is the statement separator. Thus this:
nop ;@ comment
is two statements, the first is the 'nop' instruction, while the
second contains no instructions, just the '@ comment' comment text.
This:
nop @ comment
is a single 'nop' instruction followed by a comment. And finally,
this:
nop ; comment
is two statements, the first contains the 'nop' instruction, while the
second contains the instruction 'comment', which obviously isn't
actually an instruction at all.
Why this matters is that, in the next commit, I would like to add
libopcodes syntax styling support for ARM.
The question then is how should the disassembler style the three cases
above?
As '@' is the actual comment start character then clearly the '@' and
anything after it can be styled as a comment. But what about ';' in
the second example? Style as text? Style as a comment?
And the third example is even harder, what about the 'comment' text?
Style as an instruction mnemonic? Style as text? Style as a comment?
I think the only sensible answer is to move the disassembler to use
'@' consistently as its comment character, and remove all the uses of
';'.
Then, in the next commit, it's obvious what to do.
There's obviously a *lot* of tests that get updated by this commit,
the only actual code changes are in opcodes/arm-dis.c.
Diffstat (limited to 'ld/testsuite/ld-arm/tls-gdierelax.d')
| -rw-r--r-- | ld/testsuite/ld-arm/tls-gdierelax.d | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/ld/testsuite/ld-arm/tls-gdierelax.d b/ld/testsuite/ld-arm/tls-gdierelax.d index 6f79c80..ab6d181 100644 --- a/ld/testsuite/ld-arm/tls-gdierelax.d +++ b/ld/testsuite/ld-arm/tls-gdierelax.d @@ -7,14 +7,14 @@ start address 0x[0-9a-f]+ Disassembly of section .text: [0-9a-f]+ <foo>: - [0-9a-f]+: e59f0004 ldr r0, \[pc, #4\] ; .* + [0-9a-f]+: e59f0004 ldr r0, \[pc, #4\] @ .* [0-9a-f]+: e79f0000 ldr r0, \[pc, r0\] - [0-9a-f]+: e1a00000 nop ; .* + [0-9a-f]+: e1a00000 nop @ .* [0-9a-f]+: 00008020 .word 0x00008020 [0-9a-f]+ <bar>: - [0-9a-f]+: 4801 ldr r0, \[pc, #4\] ; .* + [0-9a-f]+: 4801 ldr r0, \[pc, #4\] @ .* [0-9a-f]+: 4478 add r0, pc [0-9a-f]+: 6800 ldr r0, \[r0, #0\] - [0-9a-f]+: 46c0 nop ; .* + [0-9a-f]+: 46c0 nop @ .* [0-9a-f]+: 00008016 .word 0x00008016 |