aboutsummaryrefslogtreecommitdiff
path: root/gold
diff options
context:
space:
mode:
authorCary Coutant <ccoutant@gmail.com>2018-04-14 15:58:07 -0700
committerCary Coutant <ccoutant@gmail.com>2018-04-14 15:58:07 -0700
commitaae8280935aab812c3666d1c5c0ea099e96927cc (patch)
treedb7d76e601c10266dc6ffe8b3ac37293813059a2 /gold
parent702d167134149f420ea3bcbc194d63a2653a0c27 (diff)
downloadgdb-aae8280935aab812c3666d1c5c0ea099e96927cc.zip
gdb-aae8280935aab812c3666d1c5c0ea099e96927cc.tar.gz
gdb-aae8280935aab812c3666d1c5c0ea099e96927cc.tar.bz2
Fix bug where --icf=safe triggers segfault when linking ARM.
When checking a R_ARM_TARGET[12] relocation, we need a valid target pointer, but the garbage collection code was passing a NULL instead. gold/ PR gold/23046 * gc.h (gc_process_relocs): Pass target to scan.global_reloc_may_be_function_pointer.
Diffstat (limited to 'gold')
-rw-r--r--gold/ChangeLog6
-rw-r--r--gold/gc.h2
2 files changed, 7 insertions, 1 deletions
diff --git a/gold/ChangeLog b/gold/ChangeLog
index fa73173..b86812c 100644
--- a/gold/ChangeLog
+++ b/gold/ChangeLog
@@ -1,3 +1,9 @@
+2018-04-14 Cary Coutant <ccoutant@gmail.com>
+
+ PR gold/23046
+ * gc.h (gc_process_relocs): Pass target to
+ scan.global_reloc_may_be_function_pointer.
+
2018-04-09 Alan Modra <amodra@gmail.com>
* configure: Regenerate.
diff --git a/gold/gc.h b/gold/gc.h
index eda332c..00f383f 100644
--- a/gold/gc.h
+++ b/gold/gc.h
@@ -300,7 +300,7 @@ gc_process_relocs(
&& dst_obj != NULL
&& (!is_ordinary
|| scan.global_reloc_may_be_function_pointer(
- symtab, NULL, NULL, src_obj, src_indx, NULL, reloc,
+ symtab, NULL, target, src_obj, src_indx, NULL, reloc,
r_type, gsym)))
symtab->icf()->set_section_has_function_pointers(dst_obj, dst_indx);