diff options
| author | Alan Modra <amodra@gmail.com> | 2014-11-21 08:15:04 +1030 |
|---|---|---|
| committer | Alan Modra <amodra@gmail.com> | 2014-11-21 08:16:22 +1030 |
| commit | 3ffaac206b7169712e1d556a881ea6730ea110a7 (patch) | |
| tree | f8bc62c26fdf6aee1afe96650b897869deb6b69e /gold | |
| parent | 344d1e9ca89655827ee4b1d613bd248829978def (diff) | |
| download | gdb-3ffaac206b7169712e1d556a881ea6730ea110a7.zip gdb-3ffaac206b7169712e1d556a881ea6730ea110a7.tar.gz gdb-3ffaac206b7169712e1d556a881ea6730ea110a7.tar.bz2 | |
PPC gold doesn't check for overflow properly
* powerpc.cc (Target_powerpc::Relocate::relocate): Correct test
for undefined weaks.
Diffstat (limited to 'gold')
| -rw-r--r-- | gold/ChangeLog | 5 | ||||
| -rw-r--r-- | gold/powerpc.cc | 8 |
2 files changed, 9 insertions, 4 deletions
diff --git a/gold/ChangeLog b/gold/ChangeLog index 14b764e..66c7fca 100644 --- a/gold/ChangeLog +++ b/gold/ChangeLog @@ -1,3 +1,8 @@ +2014-11-21 Alan Modra <amodra@gmail.com> + + * powerpc.cc (Target_powerpc::Relocate::relocate): Correct test + for undefined weaks. + 2014-11-20 Alan Modra <amodra@gmail.com> * powerpc.cc (Stub_control::Stub_control): Init stub14_group_size_ diff --git a/gold/powerpc.cc b/gold/powerpc.cc index 0442e56..4c90e38 100644 --- a/gold/powerpc.cc +++ b/gold/powerpc.cc @@ -7672,10 +7672,10 @@ Target_powerpc<size, big_endian>::Relocate::relocate( break; } if (status != Powerpc_relocate_functions<size, big_endian>::STATUS_OK - && !has_stub_value - && !(gsym != NULL - && gsym->is_weak_undefined() - && is_branch_reloc(r_type))) + && (has_stub_value + || !(gsym != NULL + && gsym->is_weak_undefined() + && is_branch_reloc(r_type)))) { gold_error_at_location(relinfo, relnum, rela.get_r_offset(), _("relocation overflow")); |