diff options
| author | Cary Coutant <ccoutant@gmail.com> | 2018-03-23 09:03:34 -0700 |
|---|---|---|
| committer | Cary Coutant <ccoutant@gmail.com> | 2018-03-26 10:54:45 -0700 |
| commit | 0b7a4aa6ba5a144b7ce616e80e95d9ff944fec2e (patch) | |
| tree | 151292ce5f093ad8ca846fece8e124f5d5972937 /gold/ChangeLog | |
| parent | 4f7ae6f5059924a5acc4490880449d6410dc5c93 (diff) | |
| download | gdb-0b7a4aa6ba5a144b7ce616e80e95d9ff944fec2e.zip gdb-0b7a4aa6ba5a144b7ce616e80e95d9ff944fec2e.tar.gz gdb-0b7a4aa6ba5a144b7ce616e80e95d9ff944fec2e.tar.bz2 | |
Fix case where IR file provides symbol visibility but replacement file does not.
In PR 22868, two IR files provide conflicting visibility for a symbol.
When a def with PROTECTED visibility is seen after a def with DEFAULT
visibility, gold does not override the visibility. Later, if the
replacement object define the symbol with DEFAULT visibility, the symbol
remains DEFAULT. This was caused by a recent change to allow multiply-defined
absolute symbols, combined with the fact that the plugin framework was using
SHN_ABS as the section index for placeholder symbols. The solution is to
use a real (but arbitrary) section index.
gold/
PR gold/22868
* plugin.cc (Sized_pluginobj::do_add_symbols): Use a real section
index instead of SHN_ABS for defined symbols.
* testsuite/Makefile.am (plugin_pr22868): New test case.
* testsuite/Makefile.in: Regenerate
* testsuite/plugin_pr22868.sh: New test script.
* testsuite/plugin_pr22868_a.c: New source file.
* testsuite/plugin_pr22868_b.c: New source file.
Diffstat (limited to 'gold/ChangeLog')
| -rw-r--r-- | gold/ChangeLog | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/gold/ChangeLog b/gold/ChangeLog index 7364a63..c2613b4 100644 --- a/gold/ChangeLog +++ b/gold/ChangeLog @@ -1,3 +1,15 @@ +2018-03-26 Cary Coutant <ccoutant@gmail.com> + +gold/ + PR gold/22868 + * plugin.cc (Sized_pluginobj::do_add_symbols): Use a real section + index instead of SHN_ABS for defined symbols. + * testsuite/Makefile.am (plugin_pr22868): New test case. + * testsuite/Makefile.in: Regenerate + * testsuite/plugin_pr22868.sh: New test script. + * testsuite/plugin_pr22868_a.c: New source file. + * testsuite/plugin_pr22868_b.c: New source file. + 2018-03-23 Cary Coutant <ccoutant@gmail.com> * plugin.cc (link_or_copy_file): Remove newlines from warning messages. |