diff options
author | Youling Tang <tangyouling@loongson.cn> | 2022-04-06 23:38:21 +0100 |
---|---|---|
committer | Maciej W. Rozycki <macro@orcam.me.uk> | 2022-04-06 23:38:21 +0100 |
commit | 089169c0037bc2ae153580de56df6acceab738fc (patch) | |
tree | f150dd92164556515928055706145e5db05153ff /gdbsupport/preprocessor.h | |
parent | 8fb105930851c7a722b4794f8348f72f29721cd0 (diff) | |
download | gdb-089169c0037bc2ae153580de56df6acceab738fc.zip gdb-089169c0037bc2ae153580de56df6acceab738fc.tar.gz gdb-089169c0037bc2ae153580de56df6acceab738fc.tar.bz2 |
gdb: mips: Fix the handling of complex type of function return value
$ objdump -d outputs/gdb.base/varargs/varargs
00000001200012e8 <find_max_float_real>:
...
1200013b8: c7c10000 lwc1 $f1,0(s8)
1200013bc: c7c00004 lwc1 $f0,4(s8)
1200013c0: 46000886 mov.s $f2,$f1
1200013c4: 46000046 mov.s $f1,$f0
1200013c8: 46001006 mov.s $f0,$f2
1200013cc: 46000886 mov.s $f2,$f1
1200013d0: 03c0e825 move sp,s8
1200013d4: dfbe0038 ld s8,56(sp)
1200013d8: 67bd0080 daddiu sp,sp,128
1200013dc: 03e00008 jr ra
1200013e0: 00000000 nop
From the above disassembly, we can see that when the return value of the
function is a complex type and len <= 2 * MIPS64_REGSIZE, the return value
will be passed through $f0 and $f2, so fix the corresponding processing
in mips_n32n64_return_value().
$ make check RUNTESTFLAGS='GDB=../gdb gdb.base/varargs.exp --outdir=test'
Before applying the patch:
FAIL: gdb.base/varargs.exp: print find_max_float_real(4, fc1, fc2, fc3, fc4)
FAIL: gdb.base/varargs.exp: print find_max_double_real(4, dc1, dc2, dc3, dc4)
# of expected passes 9
# of unexpected failures 2
After applying the patch:
# of expected passes 11
This also fixes:
FAIL: gdb.base/callfuncs.exp: call inferior func with struct - returns float _Complex
Signed-off-by: Youling Tang <tangyouling@loongson.cn>
Co-Authored-By: Maciej W. Rozycki <macro@orcam.me.uk>
Diffstat (limited to 'gdbsupport/preprocessor.h')
0 files changed, 0 insertions, 0 deletions