diff options
| author | Philippe Waroquiers <philippe.waroquiers@skynet.be> | 2019-04-13 10:22:41 +0200 |
|---|---|---|
| committer | Philippe Waroquiers <philippe.waroquiers@skynet.be> | 2019-04-20 15:37:45 +0200 |
| commit | f2ae8bc88390f91cca8531823db51a8e35f0a0a0 (patch) | |
| tree | 594a7dd4f714827d016216bb852dbf8a7208ba14 /gdb | |
| parent | 4884b57f24fca3d3abf73515e09a3917ed4f356c (diff) | |
| download | gdb-f2ae8bc88390f91cca8531823db51a8e35f0a0a0.zip gdb-f2ae8bc88390f91cca8531823db51a8e35f0a0a0.tar.gz gdb-f2ae8bc88390f91cca8531823db51a8e35f0a0a0.tar.bz2 | |
Fix GDB crash when registers cannot be modified.
This crash was detected when using GDB with the valgrind gdbserver.
To reproduce:
valgrind sleep 10000
In another window:
gdb
target remote | vgdb
p printf("make sleep print something\n")
=>
terminate called after throwing an instance of 'gdb_exception_error'
Aborted
The problem is that the valgrind gdbserver does not allow to change
registers when the inferior is blocked in a system call.
GDB then raises an exception. The exception causes the destructor
of
typedef std::unique_ptr<infcall_suspend_state, infcall_suspend_state_deleter>
infcall_suspend_state_up;
to be called. This destructor itself tries to restore the value of
the registers, and fails similarly. We must catch the exception in
the destructor to avoid crashing GDB.
If the destructor encounters a problem, no warning is produced if
there is an uncaught exception, as in this case, the user will already
be informed of a problem via this exception.
With this change, no crash anymore, and all the valgrind 3.15 tests
pass succesfully.
gdb/ChangeLog
2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
* inferior.h (struct infcall_suspend_state_deleter):
Catch exception in destructor to avoid crash.
Diffstat (limited to 'gdb')
| -rw-r--r-- | gdb/ChangeLog | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 80f18cd..0bd363e 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -79,6 +79,11 @@ 2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be> + * inferior.h (struct infcall_suspend_state_deleter): + Catch exception in destructor to avoid crash. + +2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be> + * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias close to the add_com "shell". |