diff options
| author | Tom de Vries <tdevries@suse.de> | 2024-03-26 17:32:09 +0100 |
|---|---|---|
| committer | Tom de Vries <tdevries@suse.de> | 2024-03-26 17:32:09 +0100 |
| commit | eecab42fb33fcb888fbfdbf457a98a2231fd491e (patch) | |
| tree | 14e5f7daf4863df19890a0d1266228144cfb5979 /gdb | |
| parent | 818ef5f4137aaff3afdb52f8bbd3a4c3a9ffa28b (diff) | |
| download | gdb-eecab42fb33fcb888fbfdbf457a98a2231fd491e.zip gdb-eecab42fb33fcb888fbfdbf457a98a2231fd491e.tar.gz gdb-eecab42fb33fcb888fbfdbf457a98a2231fd491e.tar.bz2 | |
[gdb/testsuite] Fix valgrind tests on debian
On debian 12, I run into:
...
(gdb) target remote | vgdb --wait=2 --max-invoke-ms=2500 --pid=618591^M
Remote debugging using | vgdb --wait=2 --max-invoke-ms=2500 --pid=618591^M
relaying data between gdb and process 618591^M
warning: remote target does not support file transfer, \
attempting to access files from local filesystem.^M
Reading symbols from /lib/ld-linux-aarch64.so.1...^M
(No debugging symbols found in /lib/ld-linux-aarch64.so.1)^M
0x000000000401a980 in ?? () from /lib/ld-linux-aarch64.so.1^M
(gdb) FAIL: gdb.base/valgrind-infcall.exp: target remote for vgdb
...
The problem is that we're expecting to match either of these regexps:
...
set start_re1 " in \\.?_start "
set start_re2 "\\.?_start \\(\\) at "
...
but there are no dwarf or elf symbols present.
Fix this by also allowing:
...
set start_re3 "$::hex in \\?\\? \\(\\) from "
...
Tested on aarch64-linux.
Approved-By: Tom Tromey <tom@tromey.com>
Diffstat (limited to 'gdb')
| -rw-r--r-- | gdb/testsuite/lib/valgrind.exp | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/gdb/testsuite/lib/valgrind.exp b/gdb/testsuite/lib/valgrind.exp index 2f2d588..c952e92 100644 --- a/gdb/testsuite/lib/valgrind.exp +++ b/gdb/testsuite/lib/valgrind.exp @@ -94,7 +94,8 @@ proc vgdb_start { {active_at_startup 1} } { if { $active_at_startup } { set start_re1 " in \\.?_start " set start_re2 "\\.?_start \\(\\) at " - gdb_test "$vgdbcmd" "($start_re1|$start_re2).*" \ + set start_re3 "$::hex in \\?\\? \\(\\) from " + gdb_test "$vgdbcmd" "($start_re1|$start_re2|$start_re3).*" \ "target remote for vgdb" } else { # Let $binfile run a bit before attaching. This is a bit of a hack, |