diff options
| author | Simon Marchi <simon.marchi@polymtl.ca> | 2021-05-17 14:01:01 -0400 |
|---|---|---|
| committer | Simon Marchi <simon.marchi@polymtl.ca> | 2021-05-17 14:01:01 -0400 |
| commit | ecd0a6b35d32aa6aca913e2d0348cfdf7e78d6c3 (patch) | |
| tree | 63610a7843f0644a5b62494b6dda4b65e97b71ef /gdb | |
| parent | 413b49c2b6619a7ce16322c7f94079205031cda4 (diff) | |
| download | gdb-ecd0a6b35d32aa6aca913e2d0348cfdf7e78d6c3.zip gdb-ecd0a6b35d32aa6aca913e2d0348cfdf7e78d6c3.tar.gz gdb-ecd0a6b35d32aa6aca913e2d0348cfdf7e78d6c3.tar.bz2 | |
gdb: don't handle old == nullptr in add_alias_cmd
I don't think this can ever happen, that we add an alias command and
pass a nullptr old (target) command. Remove the "if" handling this,
replace with an assert.
gdb/ChangeLog:
* cli/cli-decode.c (add_alias_cmd): Don't handle old == 0.
Change-Id: Ibb39e8dc4e0c465fa42e6826215f30a0a0aef932
Diffstat (limited to 'gdb')
| -rw-r--r-- | gdb/ChangeLog | 4 | ||||
| -rw-r--r-- | gdb/cli/cli-decode.c | 13 |
2 files changed, 5 insertions, 12 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index c9f5181..4ff5008 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,9 @@ 2021-05-17 Simon Marchi <simon.marchi@polymtl.ca> + * cli/cli-decode.c (add_alias_cmd): Don't handle old == 0. + +2021-05-17 Simon Marchi <simon.marchi@polymtl.ca> + * cli/cli-decode.h (prefixname): Make const, move implementation to cli/cli-decode.c. * cli/cli-decode.c (cmd_list_element::prefixname): New. diff --git a/gdb/cli/cli-decode.c b/gdb/cli/cli-decode.c index a3b153f..1bfc947 100644 --- a/gdb/cli/cli-decode.c +++ b/gdb/cli/cli-decode.c @@ -310,18 +310,7 @@ add_alias_cmd (const char *name, cmd_list_element *old, enum command_class theclass, int abbrev_flag, struct cmd_list_element **list) { - if (old == 0) - { - struct cmd_list_element *prehook, *prehookee, *posthook, *posthookee; - struct cmd_list_element *aliases = delete_cmd (name, list, - &prehook, &prehookee, - &posthook, &posthookee); - - /* If this happens, it means a programmer error somewhere. */ - gdb_assert (!aliases && !prehook && !prehookee - && !posthook && ! posthookee); - return 0; - } + gdb_assert (old != nullptr); struct cmd_list_element *c = add_cmd (name, theclass, old->doc, list); |