diff options
| author | Tom Tromey <tom@tromey.com> | 2019-11-03 15:22:01 -0700 |
|---|---|---|
| committer | Tom Tromey <tom@tromey.com> | 2019-12-12 15:50:57 -0700 |
| commit | e671856cb804c977650aaeb4107948a7b963e9e9 (patch) | |
| tree | c3a11859a808fba7ecd57bed25456e301fc10631 /gdb | |
| parent | 7d7167ce1b93f8bb151daa2572314987eaeb9e3c (diff) | |
| download | gdb-e671856cb804c977650aaeb4107948a7b963e9e9.zip gdb-e671856cb804c977650aaeb4107948a7b963e9e9.tar.gz gdb-e671856cb804c977650aaeb4107948a7b963e9e9.tar.bz2 | |
Change objfile::partial_symtabs to be a unique_ptr
A plan I had a while ago was to write the DWARF index in a worker
thread. This is why objfile::partial_symtabs is a shared_ptr.
However, it turned out that doing this required keeping the objfile
alive as well. Now that objfiles are managed using shared_ptr,
there's no need for partial_symtabs to be one as well, so this patch
reverts that change.
gdb/ChangeLog
2019-12-12 Tom Tromey <tom@tromey.com>
* objfiles.h (struct objfile) <partial_symtabs>: Now a
unique_ptr.
Change-Id: I3d7831006c40d4c8f3173ba51c0c1b0a32021ae5
Diffstat (limited to 'gdb')
| -rw-r--r-- | gdb/ChangeLog | 5 | ||||
| -rw-r--r-- | gdb/objfiles.h | 2 |
2 files changed, 6 insertions, 1 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 8c26bb0..ecd2124 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,10 @@ 2019-12-12 Tom Tromey <tom@tromey.com> + * objfiles.h (struct objfile) <partial_symtabs>: Now a + unique_ptr. + +2019-12-12 Tom Tromey <tom@tromey.com> + * progspace.h (objfile_list): New typedef. (class unwrapping_objfile_iterator) (struct unwrapping_objfile_range): Newl diff --git a/gdb/objfiles.h b/gdb/objfiles.h index f0ee803..9a433dd 100644 --- a/gdb/objfiles.h +++ b/gdb/objfiles.h @@ -518,7 +518,7 @@ public: /* The partial symbol tables. */ - std::shared_ptr<psymtab_storage> partial_symtabs; + std::unique_ptr<psymtab_storage> partial_symtabs; /* The object file's BFD. Can be null if the objfile contains only minimal symbols, e.g. the run time common symbols for SunOS4. */ |