aboutsummaryrefslogtreecommitdiff
path: root/gdb
diff options
context:
space:
mode:
authorJon Turney <jon.turney@dronecode.org.uk>2020-02-29 13:33:35 +0000
committerJon Turney <jon.turney@dronecode.org.uk>2020-03-02 12:59:44 +0000
commita84bb2a0790125f5fb5df65b7873fb6076164527 (patch)
tree03dbd55f0572137ee8ab7c22485bd240adf208a9 /gdb
parentb312fea191f0118c2438198f5069d25b0b527178 (diff)
downloadgdb-a84bb2a0790125f5fb5df65b7873fb6076164527.zip
gdb-a84bb2a0790125f5fb5df65b7873fb6076164527.tar.gz
gdb-a84bb2a0790125f5fb5df65b7873fb6076164527.tar.bz2
gdb: Move defs.h before any system header in debuginfod-support.c
* defs.h includes config.h * config.h may define _GNU_SOURCE * if _GNU_SOURCE is defined, that must be before including any system header (see feature_test_macro(7)) This is necessary to ensure that a prototype for mkostemp() is brought into scope by <stdlib.h> when compiling filestuff.h, on platforms where _GNU_SOURCE isn't unconditionally defined for C++. In file included from ../../gdb/../gdbsupport/scoped_fd.h:24, from ../../gdb/debuginfod-support.c:22: ../../gdb/../gdbsupport/filestuff.h: In function ‘int gdb_mkostemp_cloexec(char*, int)’: ../../gdb/../gdbsupport/filestuff.h:59:10: error: ‘mkostemp’ was not declared in this scope; did you mean ‘mkstemp’? gdb/ChangeLog: 2020-02-29 Jon Turney <jon.turney@dronecode.org.uk> * debuginfod-support.c: Include defs.h first.
Diffstat (limited to 'gdb')
-rw-r--r--gdb/ChangeLog4
-rw-r--r--gdb/debuginfod-support.c2
2 files changed, 5 insertions, 1 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 5f49542..591ef40 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2020-02-29 Jon Turney <jon.turney@dronecode.org.uk>
+
+ * debuginfod-support.c: Include defs.h first.
+
2020-02-28 Tom de Vries <tdevries@suse.de>
* symfile.c (set_initial_language): Use default language for lookup.
diff --git a/gdb/debuginfod-support.c b/gdb/debuginfod-support.c
index e0f0fac..f4a227b 100644
--- a/gdb/debuginfod-support.c
+++ b/gdb/debuginfod-support.c
@@ -16,8 +16,8 @@
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
-#include <errno.h>
#include "defs.h"
+#include <errno.h>
#include "cli/cli-style.h"
#include "gdbsupport/scoped_fd.h"
#include "debuginfod-support.h"