diff options
| author | Michael Eager <eager@eagercon.com> | 2014-07-23 19:21:42 -0700 |
|---|---|---|
| committer | Michael Eager <eager@eagercon.com> | 2014-07-23 19:21:42 -0700 |
| commit | a52b4d3e268c10b84a48572db632d5011018e3ef (patch) | |
| tree | 599c6bbcde24b361ec71b7701b197a8ecd79b1ad /gdb | |
| parent | 11961ad8055910ed653d1d4ed0a20efeeb9ae717 (diff) | |
| download | gdb-a52b4d3e268c10b84a48572db632d5011018e3ef.zip gdb-a52b4d3e268c10b84a48572db632d5011018e3ef.tar.gz gdb-a52b4d3e268c10b84a48572db632d5011018e3ef.tar.bz2 | |
se typecast 'size_t' on 'reg', not only avoid the related warning, but
also check whether less than zero -- for 'reg' is type 'int', and sizeof
(dwarf2_to_reg_map) is less than 0x7fff.
It is quoted in gdb_assert(), so need check 'reg' whether less than zero.
And the related warning (with '-W'):
../../binutils-gdb/gdb/microblaze-tdep.c:667:3: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
ChangeLog:
* microblaze-tdep.c (microblaze_dwarf2_reg_to_regnum): Check whether
less tha zero in conditional expression.
Diffstat (limited to 'gdb')
| -rw-r--r-- | gdb/ChangeLog | 5 | ||||
| -rw-r--r-- | gdb/microblaze-tdep.c | 2 |
2 files changed, 6 insertions, 1 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 0b27e2c..f6b97de 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2014-07-23 Chen Gang <gang.chen.5i5j@gmail.com> + + * microblaze-tdep.c (microblaze_dwarf2_reg_to_regnum): Check whether + less than zero in conditional expression. + 2014-07-23 Tom Tromey <tromey@redhat.com> * make-target-delegates ($ARGS_PART): Match trailing close paren. diff --git a/gdb/microblaze-tdep.c b/gdb/microblaze-tdep.c index 7e89241..9bec260 100644 --- a/gdb/microblaze-tdep.c +++ b/gdb/microblaze-tdep.c @@ -664,7 +664,7 @@ static int dwarf2_to_reg_map[78] = static int microblaze_dwarf2_reg_to_regnum (struct gdbarch *gdbarch, int reg) { - gdb_assert (reg < sizeof (dwarf2_to_reg_map)); + gdb_assert ((size_t) reg < sizeof (dwarf2_to_reg_map)); return dwarf2_to_reg_map[reg]; } |