diff options
| author | Simon Marchi <simon.marchi@efficios.com> | 2023-02-13 14:55:13 -0500 |
|---|---|---|
| committer | Simon Marchi <simon.marchi@efficios.com> | 2023-02-14 14:25:48 -0500 |
| commit | 8eaecfb37c8ece7396303dd3122def526a223d70 (patch) | |
| tree | be3cba32a5b2cc9105541bf7d72b9e918ea70704 /gdb | |
| parent | 92a2cc556c702154fcbc69f7def2a023185f25dd (diff) | |
| download | gdb-8eaecfb37c8ece7396303dd3122def526a223d70.zip gdb-8eaecfb37c8ece7396303dd3122def526a223d70.tar.gz gdb-8eaecfb37c8ece7396303dd3122def526a223d70.tar.bz2 | |
gdb: cast return value of std::unique_ptr::release to void
My editor shows warnings like:
value.c:2784: warning: The value returned by this function should be used
value.c:2784: note: cast the expression to void to silence this warning [bugprone-unused-return-value]
These warnings come from clangd, so ultimately from one of the clang
static analyzers (probably clang-tidy).
Silence these warnings by casting to void. Add a comment to explain
why this unusual thing is done.
Change-Id: I58323959c0baf9f1b20a8d596e4c58dc77c6809a
Approved-By: Tom Tromey <tom@tromey.com>
Diffstat (limited to 'gdb')
| -rw-r--r-- | gdb/value.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/gdb/value.c b/gdb/value.c index 7873aeb..6597d0f 100644 --- a/gdb/value.c +++ b/gdb/value.c @@ -2347,9 +2347,12 @@ add_internal_function (gdb::unique_xmalloc_ptr<char> &&name, { struct cmd_list_element *cmd = do_add_internal_function (name.get (), doc.get (), handler, cookie); - doc.release (); + + /* Manually transfer the ownership of the doc and name strings to CMD by + setting the appropriate flags. */ + (void) doc.release (); cmd->doc_allocated = 1; - name.release (); + (void) name.release (); cmd->name_allocated = 1; } |