diff options
author | Tom Tromey <tromey@adacore.com> | 2024-03-19 10:49:20 -0600 |
---|---|---|
committer | Tom Tromey <tromey@adacore.com> | 2024-04-02 10:58:37 -0600 |
commit | 80c69af864ce523221ec9f439997849c91c7ba85 (patch) | |
tree | 65ac221c9956b24aea3bffa77d96bb49494fc2c8 /gdb | |
parent | 5ac754cf46210dd8e0ea69689c72ab91d92eb69d (diff) | |
download | gdb-80c69af864ce523221ec9f439997849c91c7ba85.zip gdb-80c69af864ce523221ec9f439997849c91c7ba85.tar.gz gdb-80c69af864ce523221ec9f439997849c91c7ba85.tar.bz2 |
Remove bare "except" from disassembler.py
flake8 complains about a bare "except" in disassembler.py. In this
case, the code purports to guard against some kind of user error
involving data structure corruption. I think it's better here to just
let the error occur -- py-disasm.c will show a stack trace in this
case.
Approved-By: Simon Marchi <simon.marchi@efficios.com>
Diffstat (limited to 'gdb')
-rw-r--r-- | gdb/python/lib/gdb/disassembler.py | 21 |
1 files changed, 7 insertions, 14 deletions
diff --git a/gdb/python/lib/gdb/disassembler.py b/gdb/python/lib/gdb/disassembler.py index ecf4268..2d313ae 100644 --- a/gdb/python/lib/gdb/disassembler.py +++ b/gdb/python/lib/gdb/disassembler.py @@ -93,21 +93,14 @@ def _print_insn(info): disassembled.""" def lookup_disassembler(arch): - try: - name = arch.name() - if name is None: - return None - if name in _disassemblers_dict: - return _disassemblers_dict[name] - if None in _disassemblers_dict: - return _disassemblers_dict[None] - return None - except: - # It's pretty unlikely this exception case will ever - # trigger, one situation would be if the user somehow - # corrupted the _disassemblers_dict variable such that it - # was no longer a dictionary. + name = arch.name() + if name is None: return None + if name in _disassemblers_dict: + return _disassemblers_dict[name] + if None in _disassemblers_dict: + return _disassemblers_dict[None] + return None disassembler = lookup_disassembler(info.architecture) if disassembler is None: |