diff options
| author | Tom Tromey <tom@tromey.com> | 2019-06-15 16:06:27 -0600 |
|---|---|---|
| committer | Tom Tromey <tom@tromey.com> | 2019-06-16 09:15:04 -0600 |
| commit | 730ead81dfffc181f79a4b79ba8abf6850e63596 (patch) | |
| tree | bbae31b7c54d0506190cc92b02f0343512a87604 /gdb | |
| parent | e79be6e5f33d52b2bbb6aafdc61659a4bbb55849 (diff) | |
| download | gdb-730ead81dfffc181f79a4b79ba8abf6850e63596.zip gdb-730ead81dfffc181f79a4b79ba8abf6850e63596.tar.gz gdb-730ead81dfffc181f79a4b79ba8abf6850e63596.tar.bz2 | |
Remove some NULL checks from the TUI
I found a few spots in the TUI that were NULL-checking the result of
XNEW. This cannot return NULL, so this patch removes the checks.
gdb/ChangeLog
2019-06-16 Tom Tromey <tom@tromey.com>
* tui/tui-data.c (tui_alloc_generic_win_info)
(tui_alloc_win_info, tui_add_content_elements): Remove NULL
checks.
Diffstat (limited to 'gdb')
| -rw-r--r-- | gdb/ChangeLog | 6 | ||||
| -rw-r--r-- | gdb/tui/tui-data.c | 22 |
2 files changed, 12 insertions, 16 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index af91a3c..6e58fc8 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,9 @@ +2019-06-16 Tom Tromey <tom@tromey.com> + + * tui/tui-data.c (tui_alloc_generic_win_info) + (tui_alloc_win_info, tui_add_content_elements): Remove NULL + checks. + 2019-06-16 Bernhard Heckel <bernhard.heckel@intel.com> Andrew Burgess <andrew.burgess@embecosm.com> diff --git a/gdb/tui/tui-data.c b/gdb/tui/tui-data.c index d5f7c73..7c14305 100644 --- a/gdb/tui/tui-data.c +++ b/gdb/tui/tui-data.c @@ -424,8 +424,7 @@ tui_alloc_generic_win_info (void) { struct tui_gen_win_info *win = XNEW (struct tui_gen_win_info); - if (win != NULL) - tui_init_generic_part (win); + tui_init_generic_part (win); return win; } @@ -537,11 +536,8 @@ tui_alloc_win_info (enum tui_win_type type) { struct tui_win_info *win_info = XNEW (struct tui_win_info); - if (win_info != NULL) - { - win_info->generic.type = type; - init_win_info (win_info); - } + win_info->generic.type = type; + init_win_info (win_info); return win_info; } @@ -602,15 +598,9 @@ tui_add_content_elements (struct tui_gen_win_info *win_info, for (i = index_start; (i < num_elements + index_start); i++) { element_ptr = XNEW (struct tui_win_element); - if (element_ptr != NULL) - { - win_info->content[i] = element_ptr; - init_content_element (element_ptr, win_info->type); - win_info->content_size++; - } - else /* Things must be really hosed now! We ran out of - memory!? */ - return (-1); + win_info->content[i] = element_ptr; + init_content_element (element_ptr, win_info->type); + win_info->content_size++; } } |