diff options
| author | Pedro Alves <palves@redhat.com> | 2018-11-19 15:08:46 +0000 |
|---|---|---|
| committer | Pedro Alves <palves@redhat.com> | 2018-11-19 15:08:46 +0000 |
| commit | 6769f2765db0d94eeb8437b41a925e2bd871f514 (patch) | |
| tree | 7af7e344742bfe549e4ee9d701a7c248c8fbe3e8 /gdb | |
| parent | 4f323b727743e40ce9b0bde1e19a73b4586c2f25 (diff) | |
| download | gdb-6769f2765db0d94eeb8437b41a925e2bd871f514.zip gdb-6769f2765db0d94eeb8437b41a925e2bd871f514.tar.gz gdb-6769f2765db0d94eeb8437b41a925e2bd871f514.tar.bz2 | |
gdb.base/warning.exp tweaks
#1- Check that the warning is emitted.
#2- Avoid overriding INTERNAL_GDBFLAGS, as per documentated in
gdb/testsuite/README:
~~~
The testsuite does not override a value provided by the user.
~~~
We don't actually need to tweak INTERNAL_GDBFLAGS, we just need to
append out -data-directory to GDBFLAGS, because each passed
-data-directory option leads to a call to the warning:
$ ./gdb -data-directory=foo -data-directory=bar
Warning: foo: No such file or directory.
Warning: bar: No such file or directory.
[...]
gdb/ChangeLog
2018-11-19 Pedro Alves <palves@redhat.com>
* gdb.base/warning.exp: Don't override INTERNAL_FLAGS. Use
gdb_spawn_with_cmdline_opts instead of gdb_start. Check that we
see the expected warning.
Diffstat (limited to 'gdb')
| -rw-r--r-- | gdb/testsuite/ChangeLog | 6 | ||||
| -rw-r--r-- | gdb/testsuite/gdb.base/warning.exp | 10 |
2 files changed, 11 insertions, 5 deletions
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index c0de6f2..9acaa79 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,9 @@ +2018-11-19 Pedro Alves <palves@redhat.com> + + * gdb.base/warning.exp: Don't override INTERNAL_FLAGS. Use + gdb_spawn_with_cmdline_opts instead of gdb_start. Check that we + see the expected warning. + 2018-11-16 Alan Hayward <alan.hayward@arm.com> PR gdb/22736: diff --git a/gdb/testsuite/gdb.base/warning.exp b/gdb/testsuite/gdb.base/warning.exp index 53067f4..134218a 100644 --- a/gdb/testsuite/gdb.base/warning.exp +++ b/gdb/testsuite/gdb.base/warning.exp @@ -25,12 +25,12 @@ set fd [open $tname w] puts $fd "anything" close $fd -set save $INTERNAL_GDBFLAGS -set INTERNAL_GDBFLAGS "-nw -nx -data-directory $tname" +gdb_spawn_with_cmdline_opts \ + "-iex \"set pagination off\" -data-directory $tname" -gdb_start +# Make sure we see the warning. +gdb_test "" "warning: $tname is not a directory.*" \ + "got warning" # Make sure gdb started up. gdb_test "echo 23\\n" "23" - -set INTERNAL_GDBFLAGS $save |