aboutsummaryrefslogtreecommitdiff
path: root/gdb
diff options
context:
space:
mode:
authorJan Kratochvil <jan.kratochvil@redhat.com>2011-06-07 17:26:47 +0000
committerJan Kratochvil <jan.kratochvil@redhat.com>2011-06-07 17:26:47 +0000
commit5be4dfca585c6713617a2773394ef98a4e9f3c9c (patch)
tree9c3e1ba3ac7a235add4dbab7e120fadfb7723c6a /gdb
parentf36485f09d638d253ee09de07950dd7b85a2d99e (diff)
downloadgdb-5be4dfca585c6713617a2773394ef98a4e9f3c9c.zip
gdb-5be4dfca585c6713617a2773394ef98a4e9f3c9c.tar.gz
gdb-5be4dfca585c6713617a2773394ef98a4e9f3c9c.tar.bz2
gdb/
* cli/cli-cmds.c (shell_escape): Use waitpid. * rs6000-nat.c (exec_one_dummy_insn): Likewise. gdb/testsuite/ * gdb.base/async-shell.c: New file. * gdb.base/async-shell.exp: New file.
Diffstat (limited to 'gdb')
-rw-r--r--gdb/ChangeLog6
-rw-r--r--gdb/cli/cli-cmds.c5
-rw-r--r--gdb/rs6000-nat.c2
-rw-r--r--gdb/testsuite/ChangeLog5
-rw-r--r--gdb/testsuite/gdb.base/async-shell.c22
-rw-r--r--gdb/testsuite/gdb.base/async-shell.exp42
6 files changed, 78 insertions, 4 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index b9083e8..3ec50e7 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,9 @@
+2011-06-07 Jan Kratochvil <jan.kratochvil@redhat.com>
+ Pedro Alves <pedro@codesourcery.com>
+
+ * cli/cli-cmds.c (shell_escape): Use waitpid.
+ * rs6000-nat.c (exec_one_dummy_insn): Likewise.
+
2011-06-07 Tristan Gingold <gingold@adacore.com>
* xcoffread.c (dwarf2_xcoff_names): New variable.
diff --git a/gdb/cli/cli-cmds.c b/gdb/cli/cli-cmds.c
index 7fd2f50..d4b29a21 100644
--- a/gdb/cli/cli-cmds.c
+++ b/gdb/cli/cli-cmds.c
@@ -726,7 +726,7 @@ shell_escape (char *arg, int from_tty)
chdir (current_directory);
#endif
#else /* Can fork. */
- int rc, status, pid;
+ int status, pid;
if ((pid = vfork ()) == 0)
{
@@ -750,8 +750,7 @@ shell_escape (char *arg, int from_tty)
}
if (pid != -1)
- while ((rc = wait (&status)) != pid && rc != -1)
- ;
+ waitpid (pid, &status, 0);
else
error (_("Fork failed"));
#endif /* Can fork. */
diff --git a/gdb/rs6000-nat.c b/gdb/rs6000-nat.c
index e357c4d..30e4c15 100644
--- a/gdb/rs6000-nat.c
+++ b/gdb/rs6000-nat.c
@@ -614,7 +614,7 @@ exec_one_dummy_insn (struct regcache *regcache)
do
{
- pid = wait (&status);
+ pid = waitpid (PIDGET (inferior_ptid), &status, 0);
}
while (pid != PIDGET (inferior_ptid));
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 359452d..515f0eb 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2011-06-07 Jan Kratochvil <jan.kratochvil@redhat.com>
+
+ * gdb.base/async-shell.c: New file.
+ * gdb.base/async-shell.exp: New file.
+
2011-06-06 Pedro Alves <pedro@codesourcery.com>
* gdb.threads/pending-step.exp: Add more context to SIGTRAP match.
diff --git a/gdb/testsuite/gdb.base/async-shell.c b/gdb/testsuite/gdb.base/async-shell.c
new file mode 100644
index 0000000..f09909c
--- /dev/null
+++ b/gdb/testsuite/gdb.base/async-shell.c
@@ -0,0 +1,22 @@
+/* This testcase is part of GDB, the GNU debugger.
+
+ Copyright 2011 Free Software Foundation, Inc.
+
+ This program is free software; you can redistribute it and/or modify
+ it under the terms of the GNU General Public License as published by
+ the Free Software Foundation; either version 3 of the License, or
+ (at your option) any later version.
+
+ This program is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ GNU General Public License for more details.
+
+ You should have received a copy of the GNU General Public License
+ along with this program. If not, see <http://www.gnu.org/licenses/>. */
+
+int
+main (void)
+{
+ return sleep (600);
+}
diff --git a/gdb/testsuite/gdb.base/async-shell.exp b/gdb/testsuite/gdb.base/async-shell.exp
new file mode 100644
index 0000000..b5ccd1f
--- /dev/null
+++ b/gdb/testsuite/gdb.base/async-shell.exp
@@ -0,0 +1,42 @@
+# Copyright (C) 2011 Free Software Foundation, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program. If not, see <http://www.gnu.org/licenses/>.
+
+set testfile async-shell
+if { [prepare_for_testing ${testfile}.exp ${testfile}] } {
+ return -1
+}
+
+gdb_test_no_output "set target-async on "
+gdb_test_no_output "set non-stop on"
+gdb_test "run &" "Starting program: \[^\r\n\]*"
+
+# `sleep 5' here would workaround the bug, do not sleep here.
+# "shell" could eat waitpid event from the asynchronous inferior process.
+
+gdb_test "shell echo foo" "foo"
+
+set test "interrupt"
+gdb_test_multiple $test $test {
+ -re "interrupt\r\n$gdb_prompt " {
+ pass $test
+ }
+}
+
+set test "process stopped"
+gdb_test_multiple "" $test {
+ -re "\r\n\\\[process \[0-9\]+\\\] #1 stopped\\\.\r\n" {
+ pass $test
+ }
+}