diff options
| author | Tom Tromey <tom@tromey.com> | 2018-08-15 10:05:01 -0600 |
|---|---|---|
| committer | Tom Tromey <tom@tromey.com> | 2018-08-15 10:05:01 -0600 |
| commit | 495143533ad95369811391c6e3c6dadd69d7dd67 (patch) | |
| tree | 6aae28d0673ec4e53227477baaa18a733b180ee6 /gdb | |
| parent | 07aff30e92ead6c6d662462efc6ebdf83c6b8de3 (diff) | |
| download | gdb-495143533ad95369811391c6e3c6dadd69d7dd67.zip gdb-495143533ad95369811391c6e3c6dadd69d7dd67.tar.gz gdb-495143533ad95369811391c6e3c6dadd69d7dd67.tar.bz2 | |
Use pulongest in aarch64-linux-tdep.c
While testing a patch on the buildbot, I got this error:
../../binutils-gdb/gdb/aarch64-linux-tdep.c: In function uint64_t aarch64_linux_core_read_vq(gdbarch*, bfd*):
../../binutils-gdb/gdb/aarch64-linux-tdep.c:285:29: error: format %ld expects argument of type long int, but argument 2 has type uint64_t {aka long long unsigned int} [-Werror=format=]
This patch avoids the problem by using pulongest rather than %ld.
This seems safe to me because, if aarch64-linux-tdep.c is included in
the build, then ULONGEST must be a 64-bit type.
gdb/ChangeLog
2018-08-15 Tom Tromey <tom@tromey.com>
* aarch64-linux-tdep.c (aarch64_linux_core_read_vq): Use pulongest.
Diffstat (limited to 'gdb')
| -rw-r--r-- | gdb/ChangeLog | 4 | ||||
| -rw-r--r-- | gdb/aarch64-linux-tdep.c | 5 |
2 files changed, 7 insertions, 2 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index d16920d..9fac8cc 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2018-08-15 Tom Tromey <tom@tromey.com> + + * aarch64-linux-tdep.c (aarch64_linux_core_read_vq): Use pulongest. + 2018-08-14 Jan Vrany <jan.vrany@fit.cvut.cz> * mi/mi-cmd-disas.c (mi_cmd_disassemble): Add -a option. diff --git a/gdb/aarch64-linux-tdep.c b/gdb/aarch64-linux-tdep.c index 99e6a15..389f4f4 100644 --- a/gdb/aarch64-linux-tdep.c +++ b/gdb/aarch64-linux-tdep.c @@ -282,12 +282,13 @@ aarch64_linux_core_read_vq (struct gdbarch *gdbarch, bfd *abfd) if (vq > AARCH64_MAX_SVE_VQ) { warning (_("SVE Vector length in core file not supported by this version" - " of GDB. (VQ=%ld)"), vq); + " of GDB. (VQ=%s)"), pulongest (vq)); return 0; } else if (vq == 0) { - warning (_("SVE Vector length in core file is invalid. (VQ=%ld"), vq); + warning (_("SVE Vector length in core file is invalid. (VQ=%s"), + pulongest (vq)); return 0; } |