aboutsummaryrefslogtreecommitdiff
path: root/gdb
diff options
context:
space:
mode:
authorJoel Brobecker <brobecker@gnat.com>2010-07-28 17:57:54 +0000
committerJoel Brobecker <brobecker@gnat.com>2010-07-28 17:57:54 +0000
commit385d04dc77d045a59c58f9c709ba5c7295d0bf9d (patch)
tree9f01390d34fffc11f949939466cfb8810eae4ee2 /gdb
parent34eaf5422cb5d28038fdb2be7010c2a24338822d (diff)
downloadgdb-385d04dc77d045a59c58f9c709ba5c7295d0bf9d.zip
gdb-385d04dc77d045a59c58f9c709ba5c7295d0bf9d.tar.gz
gdb-385d04dc77d045a59c58f9c709ba5c7295d0bf9d.tar.bz2
[PATCH] breakpoint_re_set fails while connecting to gdbserver.
This is a problem that I noticed on GNU/Linux, when using both GDB and GDBserver to debug an Ada program. To reproduce, use any Ada program, built with debug info ("gnatmake -g ..."). Then start the program with gdbserver: % gdbserver :4444 simple_main And then insert a breakpoint using the name of an Ada function, followed by connecting to the target server: (gdb) b simple.test_simple Breakpoint 1 at 0x401f28: file simple.adb, line 16. (gdb) tar rem :4444 Remote debugging using :4444 Reading symbols from /lib64/ld-linux-x86-64.so.2... Reading symbols from /usr/lib/debug/lib/ld-2.11.1.so...done. done. Loaded symbols for /lib64/ld-linux-x86-64.so.2 !! -> Error in re-setting breakpoint 1: Can't find member of namespace, class, !! -> struct, or union named "simple.test_simple" !! -> Hint: try 'simple.test_simple<TAB> or 'simple.test_simple<ESC-?> !! -> (Note leading single quote.) 0x00007f4db3cf2af0 in _start () from /lib64/ld-linux-x86-64.so.2 Created trace state variable $trace_timestamp for target's variable 1. The problem is related to the fact that GDB found debug symbols for ld.so in /usr/lib/debug. For debugger configured with a prefix that is different from /usr, one way to force the problem to reproduce is to use: (gdb) set debug-file-directory /usr/lib/debug (assuming that debug info has been installed at that location). The problem is that the wrong language is used to parse the breakpoint location because it gets changed from under us as a side effect of some of the code that we do in prepration for re-parsing. In particular, breakpoint_re_set_one reads: set_language (b->language); input_radix = b->input_radix; s = b->addr_string; save_current_space_and_thread (); switch_to_program_space_and_thread (b->pspace); marker_spec = b->type == bp_static_tracepoint && is_marker_spec (s); [if (marker_spec) decode_tracepoint_spec (...) else decode_line_1] What happens in our case is that debugging information gets found for ld.so. As a result, the current_frame language is C whereas it would have been unknown if we did not have debugging info. And save_current_space_and_thread() implicitly causes the current frame to be selected, which changes the language automatically if the new language is not uknown and the the language mode is auto. The fix, until all parsing routines (including decode_line_1) get upgraded to take a language, is to select the breakpoint language as late as possible. In this case, we don't need to do that until we actually try to parse the breakpoint addr_string. gdb/ChangeLog: * breakpoint.c (breakpoint_re_set_one): Move call to set_language down, just before the block that parse the breakpoint addr_string.
Diffstat (limited to 'gdb')
-rw-r--r--gdb/ChangeLog5
-rw-r--r--gdb/breakpoint.c2
2 files changed, 6 insertions, 1 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index c9fc158..630de2d 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2010-07-28 Joel Brobecker <brobecker@adacore.com>
+
+ * breakpoint.c (breakpoint_re_set_one): Move call to set_language
+ down, just before the block that parse the breakpoint addr_string.
+
2010-07-28 Tom Tromey <tromey@redhat.com>
PR c++/9946:
diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
index b53b515..50c4c02 100644
--- a/gdb/breakpoint.c
+++ b/gdb/breakpoint.c
@@ -10024,7 +10024,6 @@ breakpoint_re_set_one (void *bint)
return 0;
}
- set_language (b->language);
input_radix = b->input_radix;
s = b->addr_string;
@@ -10033,6 +10032,7 @@ breakpoint_re_set_one (void *bint)
marker_spec = b->type == bp_static_tracepoint && is_marker_spec (s);
+ set_language (b->language);
TRY_CATCH (e, RETURN_MASK_ERROR)
{
if (marker_spec)