diff options
| author | Phil Muldoon <pmuldoon@redhat.com> | 2011-10-20 13:34:17 +0000 |
|---|---|---|
| committer | Phil Muldoon <pmuldoon@redhat.com> | 2011-10-20 13:34:17 +0000 |
| commit | 27ca1a5b081f313daa1d06190b12abbe645da583 (patch) | |
| tree | 7fb46b0ea8547d61e3d993ff3e23c030480dca30 /gdb | |
| parent | 4a89cbfcf55d59f3226bd06b6439d4b2833ea736 (diff) | |
| download | gdb-27ca1a5b081f313daa1d06190b12abbe645da583.zip gdb-27ca1a5b081f313daa1d06190b12abbe645da583.tar.gz gdb-27ca1a5b081f313daa1d06190b12abbe645da583.tar.bz2 | |
2011-10-20 Phil Muldoon <pmuldoon@redhat.com>
PR python/13308
PR python/13309
* python/py-breakpoint.c (gdbpy_breakpoints): Fix List reference
leak.
* python/py-inferior.c (gdbpy_inferiors): Fix List reference
leak. Delete unused variables.
Diffstat (limited to 'gdb')
| -rw-r--r-- | gdb/ChangeLog | 10 | ||||
| -rw-r--r-- | gdb/python/py-breakpoint.c | 7 | ||||
| -rw-r--r-- | gdb/python/py-inferior.c | 9 |
3 files changed, 20 insertions, 6 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 154aee5..c9d5b26 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,15 @@ 2011-10-20 Phil Muldoon <pmuldoon@redhat.com> + PR python/13308 + PR python/13309 + + * python/py-breakpoint.c (gdbpy_breakpoints): Fix List reference + leak. + * python/py-inferior.c (gdbpy_inferiors): Fix List reference + leak. Delete unused variables. + +2011-10-20 Phil Muldoon <pmuldoon@redhat.com> + PR python/12656 * python/py-frame.c (frapy_read_var): Use const struct *block. diff --git a/gdb/python/py-breakpoint.c b/gdb/python/py-breakpoint.c index 87265e2..daceb99 100644 --- a/gdb/python/py-breakpoint.c +++ b/gdb/python/py-breakpoint.c @@ -697,7 +697,7 @@ build_bp_list (struct breakpoint *b, void *arg) PyObject * gdbpy_breakpoints (PyObject *self, PyObject *args) { - PyObject *list; + PyObject *list, *tuple; if (bppy_live == 0) Py_RETURN_NONE; @@ -715,7 +715,10 @@ gdbpy_breakpoints (PyObject *self, PyObject *args) return NULL; } - return PyList_AsTuple (list); + tuple = PyList_AsTuple (list); + Py_DECREF (list); + + return tuple; } /* Call the "stop" method (if implemented) in the breakpoint diff --git a/gdb/python/py-inferior.c b/gdb/python/py-inferior.c index afc3eb0..d6086dc 100644 --- a/gdb/python/py-inferior.c +++ b/gdb/python/py-inferior.c @@ -377,9 +377,7 @@ build_inferior_list (struct inferior *inf, void *arg) PyObject * gdbpy_inferiors (PyObject *unused, PyObject *unused2) { - int i = 0; - PyObject *list, *inferior; - struct inferior *inf; + PyObject *list, *tuple; list = PyList_New (0); if (!list) @@ -391,7 +389,10 @@ gdbpy_inferiors (PyObject *unused, PyObject *unused2) return NULL; } - return PyList_AsTuple (list); + tuple = PyList_AsTuple (list); + Py_DECREF (list); + + return tuple; } /* Membuf and memory manipulation. */ |