diff options
| author | Bruno Larsen <blarsen@redhat.com> | 2022-10-04 19:07:46 +0200 |
|---|---|---|
| committer | Bruno Larsen <blarsen@redhat.com> | 2022-11-11 10:13:48 +0100 |
| commit | 2604c0dc3b89dcf7114de4ce71b7556bf4bf6913 (patch) | |
| tree | b1ea7891b729d56a8f13d2dbe60a84d95d083f71 /gdb | |
| parent | ebe9ddbce72cb50e8d18663feafd48a7b172fab9 (diff) | |
| download | gdb-2604c0dc3b89dcf7114de4ce71b7556bf4bf6913.zip gdb-2604c0dc3b89dcf7114de4ce71b7556bf4bf6913.tar.gz gdb-2604c0dc3b89dcf7114de4ce71b7556bf4bf6913.tar.bz2 | |
gdb/testsuite: remove XFAIL on gdb.cp/temargs.exp
gdb.cp/temargs.exp last 2 tests always setup an XFAILs, despite checking
for old gcc versions. However, Clang does not fail in this test,
turning into XPASSes and slighty annoying when comparing between
compilers. To change this, make the xfails only happen if we using gcc.
Approved-by: Tom Tromey <tom@tromey.com>
Diffstat (limited to 'gdb')
| -rw-r--r-- | gdb/testsuite/gdb.cp/temargs.exp | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/gdb/testsuite/gdb.cp/temargs.exp b/gdb/testsuite/gdb.cp/temargs.exp index 05fd902..22c29cc 100644 --- a/gdb/testsuite/gdb.cp/temargs.exp +++ b/gdb/testsuite/gdb.cp/temargs.exp @@ -46,6 +46,8 @@ if {[test_compiler_info {gcc-[0-3]-*}] set have_pr_45024_fixed 0 } +set using_gcc [test_compiler_info gcc-*-*] + set line [gdb_get_line_number "Breakpoint 1" $srcfile] gdb_test "break $srcfile:$line" "Breakpoint 2.*" \ "set first breakpoint for temargs" @@ -190,10 +192,10 @@ gdb_test "print F" "&S::somefunc" "test value of F in k2_m" gdb_continue_to_breakpoint "continue to sixth breakpoint for temargs" if $have_older_template_gcc { setup_xfail "*-*-*" -} else { setup_xfail gcc/49546 "*-*-*" } +} elseif { $using_gcc } { setup_xfail gcc/49546 "*-*-*" } gdb_test "ptype F" {type = void \(\*\)\(int\)} "test type of F in k3_m" if $have_older_template_gcc { setup_xfail "*-*-*" -} else { setup_xfail gcc/49546 "*-*-*" } +} elseif { $using_gcc } { setup_xfail gcc/49546 "*-*-*" } gdb_test "print F" { = \(void \(\*\)\(int\)\) 0x[0-9a-f]+ <S3::m\(int\)>} \ "test value of F in k3_m" |