aboutsummaryrefslogtreecommitdiff
path: root/gdb
diff options
context:
space:
mode:
authorYao Qi <yao@codesourcery.com>2014-01-07 18:12:21 +0800
committerYao Qi <yao@codesourcery.com>2014-01-08 10:44:32 +0800
commit22c90ac1cd796561ba5e9e7eec0bc16c92f0c7e0 (patch)
tree256056bc59bc6306505842acb42a3aa39dac43c9 /gdb
parentd64ad97c6ba5a1deb97788fd015b60459f64a753 (diff)
downloadgdb-22c90ac1cd796561ba5e9e7eec0bc16c92f0c7e0.zip
gdb-22c90ac1cd796561ba5e9e7eec0bc16c92f0c7e0.tar.gz
gdb-22c90ac1cd796561ba5e9e7eec0bc16c92f0c7e0.tar.bz2
Fix pointer assignment with different signedness
This patch fixes these errors below: ../../binutils-gdb/gdb/spu-linux-nat.c: In function ‘spu_symbol_file_add_from_memory’: ../../binutils-gdb/gdb/spu-linux-nat.c:368:3: error: pointer targets in passing argument 2 of ‘spu_proc_xfer_spu’ differ in signedness [-Werror=pointer-sign] ../../binutils-gdb/gdb/spu-linux-nat.c:232:1: note: expected ‘gdb_byte *’ but argument is of type ‘char *’ ../../binutils-gdb/gdb/spu-linux-nat.c: In function ‘spu_xfer_partial’: ../../binutils-gdb/gdb/spu-linux-nat.c:598:7: error: pointer targets in passing argument 1 of ‘strtoulst’ differ in signedness [-Werror=pointer-sign] In file included from ../../binutils-gdb/gdb/defs.h:769:0, from ../../binutils-gdb/gdb/spu-linux-nat.c:21: ../../binutils-gdb/gdb/utils.h:43:15: note: expected ‘const char *’ but argument is of type ‘gdb_byte *’ gdb: 2014-01-08 Yao Qi <yao@codesourcery.com> * spu-linux-nat.c (spu_symbol_file_add_from_memory): Change type of 'id' to gdb_byte. Cast 'id' to 'const char *'. (spu_xfer_partial): Cast 'buf' to 'const char *'.
Diffstat (limited to 'gdb')
-rw-r--r--gdb/ChangeLog6
-rw-r--r--gdb/spu-linux-nat.c6
2 files changed, 9 insertions, 3 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index e5c7bdc..01a0c56 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,11 @@
2014-01-08 Yao Qi <yao@codesourcery.com>
+ * spu-linux-nat.c (spu_symbol_file_add_from_memory): Change
+ type of 'id' to gdb_byte. Cast 'id' to 'const char *'.
+ (spu_xfer_partial): Cast 'buf' to 'const char *'.
+
+2014-01-08 Yao Qi <yao@codesourcery.com>
+
* spu-linux-nat.c (spu_symbol_file_add_from_memory): Pass
return value of bfd_get_filename to symbol_file_add_from_bfd.
diff --git a/gdb/spu-linux-nat.c b/gdb/spu-linux-nat.c
index cfd5fd9..4c62ec7 100644
--- a/gdb/spu-linux-nat.c
+++ b/gdb/spu-linux-nat.c
@@ -359,7 +359,7 @@ spu_symbol_file_add_from_memory (int inferior_fd)
ULONGEST addr;
struct bfd *nbfd;
- char id[128];
+ gdb_byte id[128];
char annex[32];
int len;
@@ -369,7 +369,7 @@ spu_symbol_file_add_from_memory (int inferior_fd)
if (len <= 0 || len >= sizeof id)
return;
id[len] = 0;
- addr = strtoulst (id, NULL, 16);
+ addr = strtoulst ((const char *) id, NULL, 16);
if (!addr)
return;
@@ -596,7 +596,7 @@ spu_xfer_partial (struct target_ops *ops,
if (spu_proc_xfer_spu (lslr_annex, buf, NULL, 0, sizeof buf) <= 0)
return ret;
- lslr = strtoulst (buf, NULL, 16);
+ lslr = strtoulst ((const char *) buf, NULL, 16);
return spu_proc_xfer_spu (mem_annex, readbuf, writebuf,
offset & lslr, len);
}