diff options
| author | Simon Marchi <simon.marchi@efficios.com> | 2021-10-27 09:38:51 -0400 |
|---|---|---|
| committer | Simon Marchi <simon.marchi@polymtl.ca> | 2021-10-27 09:41:59 -0400 |
| commit | 5612b5d21e41796c9d6fb024c4bbf70719153373 (patch) | |
| tree | 9ec3077a7aa777c37546cbc075a451e5536c01ab /gdb/value.c | |
| parent | 437e2ff1ad8a1d5f20ebd27af2f04e1a1bcb48a7 (diff) | |
| download | gdb-5612b5d21e41796c9d6fb024c4bbf70719153373.zip gdb-5612b5d21e41796c9d6fb024c4bbf70719153373.tar.gz gdb-5612b5d21e41796c9d6fb024c4bbf70719153373.tar.bz2 | |
gdb: fix value.c build on 32-bits
When building on ARM (32-bits), we errors like this:
/home/smarchi/src/binutils-gdb/gdb/value.c: In function 'gdb::array_view<const unsigned char> value_contents_for_printing(value*)':
/home/smarchi/src/binutils-gdb/gdb/value.c:1252:35: error: narrowing conversion of 'length' from 'ULONGEST' {aka 'long long unsigned int'} to 'size_t' {aka 'unsigned int'} [-Werror=narrowing]
1252 | return {value->contents.get (), length};
| ^~~~~~
Fix that by using gdb::make_array_view, which does the appropriate
conversion.
Change-Id: I7d6f2e75d7440d248b8fb18f8272ee92954b404d
Diffstat (limited to 'gdb/value.c')
| -rw-r--r-- | gdb/value.c | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/gdb/value.c b/gdb/value.c index 42ce804..a0ce3a7 100644 --- a/gdb/value.c +++ b/gdb/value.c @@ -1155,7 +1155,8 @@ value_contents_raw (struct value *value) allocate_value_contents (value); ULONGEST length = TYPE_LENGTH (value_type (value)); - return {value->contents.get () + value->embedded_offset * unit_size, length}; + return gdb::make_array_view + (value->contents.get () + value->embedded_offset * unit_size, length); } gdb::array_view<gdb_byte> @@ -1164,7 +1165,7 @@ value_contents_all_raw (struct value *value) allocate_value_contents (value); ULONGEST length = TYPE_LENGTH (value_type (value)); - return {value->contents.get (), length}; + return gdb::make_array_view (value->contents.get (), length); } struct type * @@ -1249,7 +1250,7 @@ value_contents_for_printing (struct value *value) value_fetch_lazy (value); ULONGEST length = TYPE_LENGTH (value_type (value)); - return {value->contents.get (), length}; + return gdb::make_array_view (value->contents.get (), length); } gdb::array_view<const gdb_byte> @@ -1258,7 +1259,7 @@ value_contents_for_printing_const (const struct value *value) gdb_assert (!value->lazy); ULONGEST length = TYPE_LENGTH (value_type (value)); - return {value->contents.get (), length}; + return gdb::make_array_view (value->contents.get (), length); } gdb::array_view<const gdb_byte> |