diff options
author | Simon Marchi <simon.marchi@efficios.com> | 2021-11-22 11:27:30 -0500 |
---|---|---|
committer | Simon Marchi <simon.marchi@polymtl.ca> | 2021-11-22 13:57:49 -0500 |
commit | 06de25b7af21eb1173d7b86c5c0f37aae5ec2674 (patch) | |
tree | 257ca777e7e7c96de2844956bb61256f1ed5e111 /gdb/unittests | |
parent | 7dca2ea7ff4c2c786119e13e81a5e6b0c1bf1d2d (diff) | |
download | gdb-06de25b7af21eb1173d7b86c5c0f37aae5ec2674.zip gdb-06de25b7af21eb1173d7b86c5c0f37aae5ec2674.tar.gz gdb-06de25b7af21eb1173d7b86c5c0f37aae5ec2674.tar.bz2 |
gdb: introduce target_waitkind_str, use it in target_waitstatus::to_string
I would like to print target_waitkind values in debug messages, so I
think that a target_waitkind-to-string function would be useful. While
at it, use it in target_waitstatus::to_string. This changes the output
of target_waitstatus::to_string a bit, but I think it is for the better.
The debug messages will show a string matching exactly the
target_waitkind enumerator (minus the TARGET_WAITKIND prefix).
As a convenience, make string_appendf return the same reference to
string it got as a parameter. This allows doing this:
return string_appendf (str, "foo");
... keeping the code concise.
Change-Id: I383dffc9c78614e7d0668b1516073905e798eef7
Diffstat (limited to 'gdb/unittests')
-rw-r--r-- | gdb/unittests/common-utils-selftests.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/gdb/unittests/common-utils-selftests.c b/gdb/unittests/common-utils-selftests.c index 26d313f..aa0f452 100644 --- a/gdb/unittests/common-utils-selftests.c +++ b/gdb/unittests/common-utils-selftests.c @@ -80,7 +80,8 @@ string_vprintf_tests () /* Type of both 'string_appendf' and the 'string_vappendf_wrapper' function below. Used to run the same tests against both string_appendf and string_vappendf. */ -typedef void (string_appendf_func) (std::string &str, const char *fmt, ...) +typedef std::string &(string_appendf_func) (std::string &str, const char *fmt, + ...) ATTRIBUTE_PRINTF (2, 3); static void @@ -101,7 +102,7 @@ test_appendf_func (string_appendf_func *func) SELF_CHECK (str == "test23foo 45 bar"); } -static void ATTRIBUTE_PRINTF (2, 3) +static std::string & ATTRIBUTE_PRINTF (2, 3) string_vappendf_wrapper (std::string &str, const char *fmt, ...) { va_list vp; @@ -109,6 +110,8 @@ string_vappendf_wrapper (std::string &str, const char *fmt, ...) va_start (vp, fmt); string_vappendf (str, fmt, vp); va_end (vp); + + return str; } static void |