diff options
| author | Tom de Vries <tdevries@suse.de> | 2023-12-16 09:23:38 +0100 |
|---|---|---|
| committer | Tom de Vries <tdevries@suse.de> | 2023-12-16 09:23:38 +0100 |
| commit | bebb0dd44b98f5b6555cb75389b7b14deed9550e (patch) | |
| tree | 504a8de719a33d4dbde765276c10357f93ea5556 /gdb/tui | |
| parent | 9846e9c11081a1f268c867bd99b6354680d760f6 (diff) | |
| download | gdb-bebb0dd44b98f5b6555cb75389b7b14deed9550e.zip gdb-bebb0dd44b98f5b6555cb75389b7b14deed9550e.tar.gz gdb-bebb0dd44b98f5b6555cb75389b7b14deed9550e.tar.bz2 | |
[gdb/tui] Use more box_width in tui-regs.c
While experimenting with can_box () == false by default, I noticed two places
in tui-regs.c where we can replace a hardcoded 1 with box_width ().
It also turned out to be necessary to set scrollok to false, otherwise writing
the last char of the last line with register info will cause a scroll.
Tested on x86_64-linux.
Approved-By: Tom Tromey <tom@tromey.com>
Diffstat (limited to 'gdb/tui')
| -rw-r--r-- | gdb/tui/tui-regs.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/gdb/tui/tui-regs.c b/gdb/tui/tui-regs.c index 4c6ea8a..ba801dd 100644 --- a/gdb/tui/tui-regs.c +++ b/gdb/tui/tui-regs.c @@ -288,7 +288,7 @@ tui_data_window::display_registers_from (int start_element_no) /* Now create each data "sub" window, and write the display into it. */ - int cur_y = 1; + int cur_y = box_width (); while (i < m_regs_content.size () && cur_y <= height - box_size ()) { for (int j = 0; @@ -296,7 +296,7 @@ tui_data_window::display_registers_from (int start_element_no) j++) { /* Create the window if necessary. */ - m_regs_content[i].x = (m_item_width * j) + 1; + m_regs_content[i].x = box_width () + (m_item_width * j); m_regs_content[i].y = cur_y; m_regs_content[i].visible = true; m_regs_content[i].rerender (handle.get (), m_item_width); @@ -487,6 +487,10 @@ tui_data_window::check_register_values (frame_info_ptr frame) void tui_data_item_window::rerender (WINDOW *handle, int field_width) { + /* In case the regs window is not boxed, we'll write the last char in the + last line here, causing a scroll, so prevent that. */ + scrollok (handle, FALSE); + if (highlight) /* We ignore the return value, casting it to void in order to avoid a compiler warning. The warning itself was introduced by a patch |