diff options
| author | Patrick Palka <patrick@parcs.ath.cx> | 2015-07-02 12:27:50 -0400 |
|---|---|---|
| committer | Patrick Palka <patrick@parcs.ath.cx> | 2015-07-08 14:44:30 -0400 |
| commit | a9bd710f8777b5f4d6cbb9f5f14d6eb16f60c690 (patch) | |
| tree | a3c9fb1dc7e9594ba8c834e94baf7e88e1cf0fb7 /gdb/tui | |
| parent | 328e7bfdde7267f5e4b971bc6dca7b82aef77661 (diff) | |
| download | gdb-a9bd710f8777b5f4d6cbb9f5f14d6eb16f60c690.zip gdb-a9bd710f8777b5f4d6cbb9f5f14d6eb16f60c690.tar.gz gdb-a9bd710f8777b5f4d6cbb9f5f14d6eb16f60c690.tar.bz2 | |
tui: replace deprecated_register_changed_hook with observer
This is a straightforward replacement of the TUI's use of the
aforementioned hook with the register_changed observer. Since this was
the only user of the hook, this patch also removes the hook.
gdb/ChangeLog:
* defs.h (deprecated_register_changed_hook): Remove prototype.
* interps.c (clear_iterpreter_hooks): Remove reference to
deprecated_register_changed_hook.
* top.c (deprecated_register_changed_hook): Remove prototype.
* valops.c (value_assign): Remove reference to
deprecated_register_changed_hook.
* tui/tui-hooks.c (tui_register_changed): Add parameter "frame".
Add comment documenting the function.
(tui_register_changed_observer): Define.
(tui_install_hooks): Remove reference to
deprecated_register_changed_hook. Set
tui_register_changed_observer.
(tui_remove_hooks): Remove reference to
deprecated_register_changed_hook. Unset
tui_register_changed_observer.
Diffstat (limited to 'gdb/tui')
| -rw-r--r-- | gdb/tui/tui-hooks.c | 18 |
1 files changed, 13 insertions, 5 deletions
diff --git a/gdb/tui/tui-hooks.c b/gdb/tui/tui-hooks.c index 0eb2f07..c885108 100644 --- a/gdb/tui/tui-hooks.c +++ b/gdb/tui/tui-hooks.c @@ -66,11 +66,18 @@ tui_new_objfile_hook (struct objfile* objfile) /* Prevent recursion of deprecated_register_changed_hook(). */ static int tui_refreshing_registers = 0; +/* Observer for the register_changed notification. */ + static void -tui_register_changed_hook (int regno) +tui_register_changed (struct frame_info *frame, int regno) { struct frame_info *fi; + /* The frame of the register that was changed may differ from the selected + frame, but we only want to show the register values of the selected frame. + And even if the frames differ a register change made in one can still show + up in the other. So we always use the selected frame here, and ignore + FRAME. */ fi = get_selected_frame (NULL); if (tui_refreshing_registers == 0) { @@ -226,6 +233,7 @@ static struct observer *tui_inferior_exit_observer; static struct observer *tui_about_to_proceed_observer; static struct observer *tui_before_prompt_observer; static struct observer *tui_normal_stop_observer; +static struct observer *tui_register_changed_observer; /* Install the TUI specific hooks. */ void @@ -253,8 +261,8 @@ tui_install_hooks (void) = observer_attach_before_prompt (tui_before_prompt); tui_normal_stop_observer = observer_attach_normal_stop (tui_normal_stop); - - deprecated_register_changed_hook = tui_register_changed_hook; + tui_register_changed_observer + = observer_attach_register_changed (tui_register_changed); } /* Remove the TUI specific hooks. */ @@ -263,8 +271,6 @@ tui_remove_hooks (void) { deprecated_print_frame_info_listing_hook = 0; deprecated_query_hook = 0; - deprecated_register_changed_hook = 0; - /* Remove our observers. */ observer_detach_breakpoint_created (tui_bp_created_observer); tui_bp_created_observer = NULL; @@ -280,6 +286,8 @@ tui_remove_hooks (void) tui_before_prompt_observer = NULL; observer_detach_normal_stop (tui_normal_stop_observer); tui_normal_stop_observer = NULL; + observer_detach_register_changed (tui_register_changed_observer); + tui_register_changed_observer = NULL; } void _initialize_tui_hooks (void); |