diff options
| author | Tom Tromey <tom@tromey.com> | 2019-11-12 17:08:25 -0700 |
|---|---|---|
| committer | Tom Tromey <tom@tromey.com> | 2019-12-20 09:15:50 -0700 |
| commit | 1ae58f0c640ccef6ae9cc9b349547bb552274b69 (patch) | |
| tree | 9aba4df958f67834977290f5b9177f1e74bb41d2 /gdb/tui/tui-stack.c | |
| parent | 039298ec451ecf1fa1b9ff1771168b0a5b3a6f68 (diff) | |
| download | gdb-1ae58f0c640ccef6ae9cc9b349547bb552274b69.zip gdb-1ae58f0c640ccef6ae9cc9b349547bb552274b69.tar.gz gdb-1ae58f0c640ccef6ae9cc9b349547bb552274b69.tar.bz2 | |
Simplify tui_source_window_base::maybe_update method
tui_source_window_base::maybe_update takes a symtab_and_line, plus a
separate line number and PC. Because a symtab_and_line already holds
a line number and a PC, it is possible to remove these extra
parameters.
gdb/ChangeLog
2019-12-20 Tom Tromey <tom@tromey.com>
* tui/tui-winsource.h (struct tui_source_window_base)
<maybe_update>: Remove line_no and addr parameters.
* tui/tui-stack.c (tui_show_frame_info): Set PC on sal. Update.
* tui/tui-source.h (struct tui_source_window) <maybe_update>:
Update.
* tui/tui-source.c (tui_source_window::maybe_update): Remove
line_no and addr parameters.
* tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
Update.
* tui/tui-disasm.c (tui_disasm_window::maybe_update): Remove
line_no and addr parameters.
Change-Id: I33d8e1a669a179544edb4197f5f7c5429dfc368e
Diffstat (limited to 'gdb/tui/tui-stack.c')
| -rw-r--r-- | gdb/tui/tui-stack.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/gdb/tui/tui-stack.c b/gdb/tui/tui-stack.c index 7803b95..4f6fe8e 100644 --- a/gdb/tui/tui-stack.c +++ b/gdb/tui/tui-stack.c @@ -341,9 +341,13 @@ tui_show_frame_info (struct frame_info *fi) if (!locator_changed_p) return 0; + /* find_frame_sal does not always set PC, but we want to ensure + that it is available in the SAL. */ + sal.pc = pc; + for (struct tui_source_window_base *win_info : tui_source_windows ()) { - win_info->maybe_update (fi, sal, locator->line_no, locator->addr); + win_info->maybe_update (fi, sal); win_info->update_exec_info (); } |