aboutsummaryrefslogtreecommitdiff
path: root/gdb/tui/tui-disasm.c
diff options
context:
space:
mode:
authorTom Tromey <tom@tromey.com>2019-07-23 15:34:40 -0600
committerTom Tromey <tom@tromey.com>2019-09-20 13:49:04 -0600
commitf14bec587fd0b695bbb8dcfe92169b4dae76245d (patch)
tree52ec0af1727c25401a8c5518e14567cca8f9bf3f /gdb/tui/tui-disasm.c
parent78d5933a43f8a4dd5fd54f5344a7dd9c2d4b8769 (diff)
downloadgdb-f14bec587fd0b695bbb8dcfe92169b4dae76245d.zip
gdb-f14bec587fd0b695bbb8dcfe92169b4dae76245d.tar.gz
gdb-f14bec587fd0b695bbb8dcfe92169b4dae76245d.tar.bz2
Change tui_source_element::line to be a unique_xmalloc_ptr
This changes tui_source_element::line to be a unique_xmalloc_ptr, removing some manual memory management. gdb/ChangeLog 2019-09-20 Tom Tromey <tom@tromey.com> * tui/tui-winsource.h (~tui_source_element): Remove. (tui_source_element): Update. (struct tui_source_element) <line>: Now a unique_xmalloc_ptr. * tui/tui-winsource.c (tui_show_source_line): Update. * tui/tui-source.c (tui_source_window::set_contents): Update. * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
Diffstat (limited to 'gdb/tui/tui-disasm.c')
-rw-r--r--gdb/tui/tui-disasm.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/gdb/tui/tui-disasm.c b/gdb/tui/tui-disasm.c
index 1d019ca..2a33132 100644
--- a/gdb/tui/tui-disasm.c
+++ b/gdb/tui/tui-disasm.c
@@ -231,11 +231,10 @@ tui_disasm_window::set_contents (struct gdbarch *arch,
strcpy (line + insn_pos, asm_lines[i].insn);
/* Now copy the line taking the offset into account. */
- xfree (src->line);
if (strlen (line) > offset)
- src->line = xstrndup (&line[offset], line_width);
+ src->line.reset (xstrndup (&line[offset], line_width));
else
- src->line = xstrdup ("");
+ src->line.reset (xstrdup (""));
src->line_or_addr.loa = LOA_ADDRESS;
src->line_or_addr.u.addr = asm_lines[i].addr;