aboutsummaryrefslogtreecommitdiff
path: root/gdb/testsuite
diff options
context:
space:
mode:
authorTom de Vries <tdevries@suse.de>2023-07-22 11:00:25 +0200
committerTom de Vries <tdevries@suse.de>2023-07-22 11:00:25 +0200
commitb40b1e4f9a3c95588a2f5773bbd825956c832b6b (patch)
tree6811e71f0b0f44b3cd38092440218ab1a5a547e9 /gdb/testsuite
parent09075d5d4a2b6dbbc3ca20e2b963799b4c5d638d (diff)
downloadgdb-b40b1e4f9a3c95588a2f5773bbd825956c832b6b.zip
gdb-b40b1e4f9a3c95588a2f5773bbd825956c832b6b.tar.gz
gdb-b40b1e4f9a3c95588a2f5773bbd825956c832b6b.tar.bz2
[gdb/testsuite] Improve gdb.arch/arm-pthread_cond_timedwait-bt.exp
I noticed in test-case gdb.arch/arm-pthread_cond_timedwait-bt.exp that prepare_for_testing is used, followed by a clean_restart. This calls clean_restart twice in a row. Fix this by using build_executable instead. Also, I noticed that the test-case requires an SVC instruction, so add a require to limit the test-case to supported architectures. While we're at it, run M-x indent-region in emacs to fix indentation. Tested on x86_64-linux.
Diffstat (limited to 'gdb/testsuite')
-rw-r--r--gdb/testsuite/gdb.arch/arm-pthread_cond_timedwait-bt.exp9
1 files changed, 6 insertions, 3 deletions
diff --git a/gdb/testsuite/gdb.arch/arm-pthread_cond_timedwait-bt.exp b/gdb/testsuite/gdb.arch/arm-pthread_cond_timedwait-bt.exp
index 17f8d68..e64fa46 100644
--- a/gdb/testsuite/gdb.arch/arm-pthread_cond_timedwait-bt.exp
+++ b/gdb/testsuite/gdb.arch/arm-pthread_cond_timedwait-bt.exp
@@ -17,21 +17,24 @@
# syscall is active. But some active syscalls keep PC pointing to the SVC
# instruction itself.
+# Require an architecture with the SVC instruction.
+require {is_any_target "aarch64*-*-*" "arm*-*-*"}
+
# See if we have target board readnow.exp or similar. We're using
# --readnever, which is not allowed in combination with --readnow.
require !readnow
standard_testfile
-if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile} \
- {debug pthreads}] } {
+if { [build_executable "failed to prepare" ${testfile} ${srcfile} \
+ {debug pthreads}] } {
return
}
save_vars { GDBFLAGS } {
append GDBFLAGS " --readnever"
if { [clean_restart ${binfile}] == -1 } {
- return -1
+ return -1
}
}