aboutsummaryrefslogtreecommitdiff
path: root/gdb/testsuite
diff options
context:
space:
mode:
authorSimon Marchi <simon.marchi@polymtl.ca>2021-11-30 21:00:59 -0500
committerSimon Marchi <simon.marchi@polymtl.ca>2021-11-30 21:05:26 -0500
commit6976b5b96120ad71af4cec2891f3d8ae7869e4e0 (patch)
treedb32ef6209f4974b42e0cbedf63a311f9806f1df /gdb/testsuite
parent360ef3b94a9120729ae36f1ca9e7e1935d5788eb (diff)
downloadgdb-6976b5b96120ad71af4cec2891f3d8ae7869e4e0.zip
gdb-6976b5b96120ad71af4cec2891f3d8ae7869e4e0.tar.gz
gdb-6976b5b96120ad71af4cec2891f3d8ae7869e4e0.tar.bz2
gdb.base/corefile-buildid.exp: fix DUPLICATEs when failing to generate a core file
When my system isn't properly configured to generate core files in the local directory, I see these DUPLICATEs: DUPLICATE: gdb.base/corefile-buildid.exp: could not generate core file Fix that by having a single with_test_prefix around that message and what follows. Change-Id: I4ac245fcce1c666db56e3bad3582aa17f183dcba
Diffstat (limited to 'gdb/testsuite')
-rw-r--r--gdb/testsuite/gdb.base/corefile-buildid.exp38
1 files changed, 19 insertions, 19 deletions
diff --git a/gdb/testsuite/gdb.base/corefile-buildid.exp b/gdb/testsuite/gdb.base/corefile-buildid.exp
index 15509be..e1703d6 100644
--- a/gdb/testsuite/gdb.base/corefile-buildid.exp
+++ b/gdb/testsuite/gdb.base/corefile-buildid.exp
@@ -257,30 +257,30 @@ proc do_corefile_buildid_tests {args} {
lappend suffix "sepdebug"
}
- # Find the core file.
- set corefile [core_find $program_to_run]
- if {$corefile == ""} {
- untested "could not generate core file"
- return
- }
- verbose -log "corefile is $corefile"
+ with_test_prefix "[join $suffix \ ]" {
+ # Find the core file.
+ set corefile [core_find $program_to_run]
+ if {$corefile == ""} {
+ untested "could not generate core file"
+ return
+ }
+ verbose -log "corefile is $corefile"
- # Grab the build-id from the binary, removing ".debug" from the end.
- set buildid [build_id_debug_filename_get $program_to_run]
- if {$buildid == ""} {
- untested "binary for [join $suffix \ ] has no build-id"
- }
- regsub {\.debug$} $buildid {} buildid
- verbose -log "build-id is $buildid"
+ # Grab the build-id from the binary, removing ".debug" from the end.
+ set buildid [build_id_debug_filename_get $program_to_run]
+ if {$buildid == ""} {
+ untested "binary has no build-id"
+ }
+ regsub {\.debug$} $buildid {} buildid
+ verbose -log "build-id is $buildid"
- with_test_prefix "[join $suffix \ ]" {
locate_exec_from_core_build_id $corefile $buildid \
[join $suffix -] $sepdebug false $shared
- }
- with_test_prefix "symlink [join $suffix \ ]" {
- locate_exec_from_core_build_id $corefile $buildid \
- [join $suffix -] $sepdebug true $shared
+ with_test_prefix "symlink" {
+ locate_exec_from_core_build_id $corefile $buildid \
+ [join $suffix -] $sepdebug true $shared
+ }
}
}