aboutsummaryrefslogtreecommitdiff
path: root/gdb/testsuite
diff options
context:
space:
mode:
authorTom de Vries <tdevries@suse.de>2023-02-28 15:50:23 +0100
committerTom de Vries <tdevries@suse.de>2023-02-28 15:50:23 +0100
commit0c132dac7f21062f19d47982697f0a223ad430ed (patch)
tree911a521c387e2911374128134188c7b87881ab37 /gdb/testsuite
parenteae679b9c7760e994c85695946c6b69a227dc69b (diff)
downloadgdb-0c132dac7f21062f19d47982697f0a223ad430ed.zip
gdb-0c132dac7f21062f19d47982697f0a223ad430ed.tar.gz
gdb-0c132dac7f21062f19d47982697f0a223ad430ed.tar.bz2
[gdb/testsuite] Fix gdb.python/py-breakpoint.exp timeouts
On powerpc64le-linux, I run into two timeouts: ... FAIL: gdb.python/py-breakpoint.exp: test_watchpoints: \ Test watchpoint write (timeout) FAIL: gdb.python/py-breakpoint.exp: test_bkpt_internal: \ Test watchpoint write (timeout) ... In this case, hw watchpoints are not supported, and using sw watchpoints is slow. Most of the time is spent in handling a try-catch, which triggers a malloc. I think this bit is more relevant for the "catch throw" part of the test-case, so fix the timeouts by setting the watchpoints after the try-catch. Tested on x86_64-linux and powerpc64le-linux.
Diffstat (limited to 'gdb/testsuite')
-rw-r--r--gdb/testsuite/gdb.python/py-breakpoint.c2
-rw-r--r--gdb/testsuite/gdb.python/py-breakpoint.exp6
2 files changed, 6 insertions, 2 deletions
diff --git a/gdb/testsuite/gdb.python/py-breakpoint.c b/gdb/testsuite/gdb.python/py-breakpoint.c
index 0f791da..1fb3416 100644
--- a/gdb/testsuite/gdb.python/py-breakpoint.c
+++ b/gdb/testsuite/gdb.python/py-breakpoint.c
@@ -60,6 +60,8 @@ int main (int argc, char *argv[])
/* Nothing. */
}
+ i = -1; /* Past throw-catch. */
+
for (i = 0; i < 10; i++)
{
result += multiply (foo); /* Break at multiply. */
diff --git a/gdb/testsuite/gdb.python/py-breakpoint.exp b/gdb/testsuite/gdb.python/py-breakpoint.exp
index 9535040..ab81b7a 100644
--- a/gdb/testsuite/gdb.python/py-breakpoint.exp
+++ b/gdb/testsuite/gdb.python/py-breakpoint.exp
@@ -36,6 +36,8 @@ if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile} ${options}]
return -1
}
+set past_throw_catch_line [gdb_get_line_number "Past throw-catch."]
+
proc_with_prefix test_bkpt_basic { } {
global srcfile testfile hex decimal
@@ -293,7 +295,7 @@ proc_with_prefix test_watchpoints { } {
gdb_test_no_output "set can-use-hw-watchpoints 0" ""
}
- if {![runto_main]} {
+ if {![runto $srcfile:$::past_throw_catch_line]} {
return 0
}
@@ -316,7 +318,7 @@ proc_with_prefix test_bkpt_internal { } {
if {!$allow_hw_watchpoint_tests_p} {
gdb_test_no_output "set can-use-hw-watchpoints 0" ""
}
- if {![runto_main]} {
+ if {![runto $srcfile:$::past_throw_catch_line]} {
return 0
}
delete_breakpoints