diff options
author | Pedro Alves <pedro@palves.net> | 2022-06-07 20:11:32 +0100 |
---|---|---|
committer | Pedro Alves <pedro@palves.net> | 2022-06-08 14:06:38 +0100 |
commit | bc2220c89de813bf67d4172a4c483d1e2b843366 (patch) | |
tree | 3dcd343082bab566d49080f7745a51d7e5fe8d2b /gdb/testsuite/lib | |
parent | 57698478b75319a962b899c3f8d3a03baa5eaab4 (diff) | |
download | gdb-bc2220c89de813bf67d4172a4c483d1e2b843366.zip gdb-bc2220c89de813bf67d4172a4c483d1e2b843366.tar.gz gdb-bc2220c89de813bf67d4172a4c483d1e2b843366.tar.bz2 |
aarch64: Add fallback if ARM_CC_FOR_TARGET not set
On Aarch64, you can set ARM_CC_FOR_TARGET to point to the 32-bit
compiler to use when testing gdb.multi/multi-arch.exp and
gdb.multi/multi-arch-exec.exp. If you don't set it, then those
testcases don't run.
I guess that approximately nobody remembers to set ARM_CC_FOR_TARGET.
This commit adds a fallback. If ARM_CC_FOR_TARGET is not set, and
testing for Linux, try arm-linux-gnueabi-gcc,
arm-none-linux-gnueabi-gcc, arm-linux-gnueabihf-gcc as 32-bit
compilers, making sure that the produced executable runs on the target
machine before claiming that the compiler produces useful executables.
Change-Id: Iefe5865d5fc84b4032eaff7f4c5c61582bf75c39
Diffstat (limited to 'gdb/testsuite/lib')
-rw-r--r-- | gdb/testsuite/lib/gdb.exp | 55 |
1 files changed, 55 insertions, 0 deletions
diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index 4024501..6a3fed1 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -8666,5 +8666,60 @@ proc get_set_option_choices {set_cmd} { return $values } +# Return the compiler that can generate 32-bit ARM executables. Used +# when testing biarch support on Aarch64. If ARM_CC_FOR_TARGET is +# set, use that. If not, try a few common compiler names, making sure +# that the executable they produce can run. + +gdb_caching_proc arm_cc_for_target { + if {[info exists ARM_CC_FOR_TARGET]} { + # If the user specified the compiler explicitly, then don't + # check whether the resulting binary runs outside GDB. Assume + # that it does, and if it turns out it doesn't, then the user + # should get loud FAILs, instead of UNSUPPORTED. + return $ARM_CC_FOR_TARGET + } + + # Fallback to a few common compiler names. Also confirm the + # produced binary actually runs on the system before declaring + # we've found the right compiler. + + if [istarget "*-linux*-*"] { + set compilers { + arm-linux-gnueabi-gcc + arm-none-linux-gnueabi-gcc + arm-linux-gnueabihf-gcc + } + } else { + set compilers {} + } + + foreach compiler $compilers { + if {![is_remote host] && [which $compiler] == 0} { + # Avoid "default_target_compile: Can't find + # $compiler." warning issued from gdb_compile. + continue + } + + set src { int main() { return 0; } } + if {[gdb_simple_compile aarch64-32bit \ + $src \ + executable [list compiler=$compiler]]} { + + set result [remote_exec target $obj] + set status [lindex $result 0] + set output [lindex $result 1] + + file delete $obj + + if { $output == "" && $status == 0} { + return $compiler + } + } + } + + return "" +} + # Always load compatibility stuff. load_lib future.exp |