aboutsummaryrefslogtreecommitdiff
path: root/gdb/testsuite/gdb.tui
diff options
context:
space:
mode:
authorAndrew Burgess <aburgess@redhat.com>2022-02-01 16:53:56 +0000
committerAndrew Burgess <aburgess@redhat.com>2022-04-03 15:31:46 +0100
commit47b8e12ffd0ecf924836aed55eb63b9e5d9e8ea1 (patch)
treee7f2f9027d1d38f3983f2f2e0727d399906f17b9 /gdb/testsuite/gdb.tui
parent80b2eb3c34c06bbd139216ad534e91e36a7eff10 (diff)
downloadgdb-47b8e12ffd0ecf924836aed55eb63b9e5d9e8ea1.zip
gdb-47b8e12ffd0ecf924836aed55eb63b9e5d9e8ea1.tar.gz
gdb-47b8e12ffd0ecf924836aed55eb63b9e5d9e8ea1.tar.bz2
gdb/tui: avoid fp exception when applying layouts
Consider: (gdb) tui enable (gdb) layout src (gdb) tui new-layout conly cmd 1 (gdb) layout conly After this, with current master, gdb crashes with a floating-point exception. The problem is that in tui_layout_split::apply, when we switch from 'src' to 'conly', we will try to retain the cmd window height. As such, the cmd window will become a fixed size window, which decreases the available_size, but doesn't count towards the total_weight. As the cmd window is the only window, the total_weight stays at zero, and, when we move into step 2, where we attempt to size the windows, we perform a divide by zero, and crash. After this commit we avoid the divide by zero, and just directly set the window size based on the fixed size. There is still a problem after this commit, when the conly layout is selected the cmd window retains its original height, which will only be part of the terminal. The rest of the terminal is left unused. This issue will be addressed in a later commit, this commit is just about the floating-point exception.
Diffstat (limited to 'gdb/testsuite/gdb.tui')
-rw-r--r--gdb/testsuite/gdb.tui/new-layout.exp3
1 files changed, 2 insertions, 1 deletions
diff --git a/gdb/testsuite/gdb.tui/new-layout.exp b/gdb/testsuite/gdb.tui/new-layout.exp
index d3d34af..66048e6 100644
--- a/gdb/testsuite/gdb.tui/new-layout.exp
+++ b/gdb/testsuite/gdb.tui/new-layout.exp
@@ -70,7 +70,8 @@ set layouts \
{{0 0 80 15}} ""] \
[list h "{-horizontal asm 1 src 1} 1 status 0 cmd 1" \
{{0 0 40 15} {39 0 41 15}} \
- "$hex <main>.*21.*return 0"]]
+ "$hex <main>.*21.*return 0"] \
+ [list cmd_only "cmd 1" {} ""]]
# Helper function to verify a list of boxes.
proc check_boxes {boxes} {