diff options
author | Simon Marchi <simon.marchi@polymtl.ca> | 2021-09-30 11:52:21 -0400 |
---|---|---|
committer | Simon Marchi <simon.marchi@polymtl.ca> | 2021-09-30 15:27:39 -0400 |
commit | 4dfef5be6812dd7abfbc8f18e9c0384f2522b511 (patch) | |
tree | 90aa986d915c17f2320655298e2799d3a2cd1841 /gdb/testsuite/gdb.trace | |
parent | 2fed9db40b1179f62c6fb0f2cacfb0db6b50af46 (diff) | |
download | gdb-4dfef5be6812dd7abfbc8f18e9c0384f2522b511.zip gdb-4dfef5be6812dd7abfbc8f18e9c0384f2522b511.tar.gz gdb-4dfef5be6812dd7abfbc8f18e9c0384f2522b511.tar.bz2 |
gdb/testsuite: make runto_main not pass no-message to runto
As follow-up to this discussion:
https://sourceware.org/pipermail/gdb-patches/2020-August/171385.html
... make runto_main not pass no-message to runto. This means that if we
fail to run to main, for some reason, we'll emit a FAIL. This is the
behavior we want the majority of (if not all) the time.
Without this, we rely on tests logging a failure if runto_main fails,
otherwise. They do so in a very inconsisteny mannet, sometimes using
"fail", "unsupported" or "untested". The messages also vary widly.
This patch removes all these messages as well.
Also, remove a few "fail" where we call runto (and not runto_main). by
default (without an explicit no-message argument), runto prints a
failure already. In two places, gdb.multi/multi-re-run.exp and
gdb.python/py-pp-registration.exp, remove "message" passed to runto.
This removes a few PASSes that we don't care about (but FAILs will still
be printed if we fail to run to where we want to). This aligns their
behavior with the rest of the testsuite.
Change-Id: Ib763c98c5f4fb6898886b635210d7c34bd4b9023
Diffstat (limited to 'gdb/testsuite/gdb.trace')
34 files changed, 0 insertions, 76 deletions
diff --git a/gdb/testsuite/gdb.trace/actions-changed.exp b/gdb/testsuite/gdb.trace/actions-changed.exp index 453af1f..44e9ad0 100644 --- a/gdb/testsuite/gdb.trace/actions-changed.exp +++ b/gdb/testsuite/gdb.trace/actions-changed.exp @@ -165,7 +165,6 @@ proc test_actions_changed { } { clean_restart $testfile if ![runto_main] { - fail "can't run to main to check for trace support" return -1 } diff --git a/gdb/testsuite/gdb.trace/actions.exp b/gdb/testsuite/gdb.trace/actions.exp index 787df23..7d3bd65 100644 --- a/gdb/testsuite/gdb.trace/actions.exp +++ b/gdb/testsuite/gdb.trace/actions.exp @@ -247,7 +247,6 @@ gdb_load $binfile gdb_breakpoint "main" gdb_run_cmd if {[gdb_test "" "Breakpoint .*"] != 0} { - fail "can't run to main" return -1 } diff --git a/gdb/testsuite/gdb.trace/backtrace.exp b/gdb/testsuite/gdb.trace/backtrace.exp index 9a03ca4..dccd9ad 100644 --- a/gdb/testsuite/gdb.trace/backtrace.exp +++ b/gdb/testsuite/gdb.trace/backtrace.exp @@ -32,7 +32,6 @@ if [prepare_for_testing "failed to prepare" $executable $srcfile \ } if ![runto_main] { - fail "can't run to main to check for trace support" return -1 } diff --git a/gdb/testsuite/gdb.trace/change-loc.exp b/gdb/testsuite/gdb.trace/change-loc.exp index f2ed8fd..f3caa74 100644 --- a/gdb/testsuite/gdb.trace/change-loc.exp +++ b/gdb/testsuite/gdb.trace/change-loc.exp @@ -54,7 +54,6 @@ gdb_load_shlib $lib_sl1 gdb_load_shlib $lib_sl2 if ![runto_main] { - fail "can't run to main to check for trace support" return -1 } @@ -75,7 +74,6 @@ proc tracepoint_change_loc_1 { trace_type } { clean_restart ${testfile} if ![runto_main] { - fail "can't run to main" return -1 } gdb_test_no_output "delete break 1" @@ -303,7 +301,6 @@ proc tracepoint_install_in_trace_disabled { trace_type } { clean_restart ${testfile} if ![runto_main] { - fail "can't run to main" return -1 } diff --git a/gdb/testsuite/gdb.trace/circ.exp b/gdb/testsuite/gdb.trace/circ.exp index 820f569..f3c6b6c 100644 --- a/gdb/testsuite/gdb.trace/circ.exp +++ b/gdb/testsuite/gdb.trace/circ.exp @@ -74,7 +74,6 @@ proc run_trace_experiment { } { } if { ![runto_main] } { - fail "can't run to main to check for trace support" return -1 } @@ -210,7 +209,6 @@ with_test_prefix "normal buffer" { clean_restart $testfile if { ![runto_main] } { - fail "can't run to main" return 1 } @@ -234,7 +232,6 @@ with_test_prefix "small buffer" { clean_restart $testfile if { ![runto_main] } { - fail "can't run to main" return 1 } @@ -260,7 +257,6 @@ with_test_prefix "circular buffer" { clean_restart $testfile if { ![runto_main] } { - fail "can't run to main" return 1 } diff --git a/gdb/testsuite/gdb.trace/disconnected-tracing.exp b/gdb/testsuite/gdb.trace/disconnected-tracing.exp index 88e8c9e..b26c80e 100644 --- a/gdb/testsuite/gdb.trace/disconnected-tracing.exp +++ b/gdb/testsuite/gdb.trace/disconnected-tracing.exp @@ -33,7 +33,6 @@ if [prepare_for_testing "failed to prepare" $executable $srcfile \ } if ![runto_main] { - fail "can't run to main to check for trace support" return -1 } @@ -53,7 +52,6 @@ proc disconnected_tracing { } { # Start with a fresh gdb. clean_restart ${executable} if ![runto_main] { - fail "can't run to main" return -1 } @@ -116,7 +114,6 @@ proc disconnected_tfind { } { # Start with a fresh gdb. clean_restart ${executable} if ![runto_main] { - fail "can't run to main" return -1 } diff --git a/gdb/testsuite/gdb.trace/entry-values.exp b/gdb/testsuite/gdb.trace/entry-values.exp index 3695a1e..bd8a8c5 100644 --- a/gdb/testsuite/gdb.trace/entry-values.exp +++ b/gdb/testsuite/gdb.trace/entry-values.exp @@ -173,7 +173,6 @@ if {[gdb_compile [list ${binfile}1.o ${binfile}2.o] \ clean_restart ${testfile} if ![runto_main] { - fail "can't run to main" return -1 } @@ -208,7 +207,6 @@ clean_restart $binfile load_lib "trace-support.exp" if ![runto_main] { - fail "can't run to main to check for trace support" return -1 } diff --git a/gdb/testsuite/gdb.trace/ftrace-lock.exp b/gdb/testsuite/gdb.trace/ftrace-lock.exp index 2c87b85..33842cf 100644 --- a/gdb/testsuite/gdb.trace/ftrace-lock.exp +++ b/gdb/testsuite/gdb.trace/ftrace-lock.exp @@ -45,7 +45,6 @@ if { [gdb_compile_pthreads "$srcdir/$subdir/$srcfile" $binfile executable $optio clean_restart ${testfile} if ![runto_main] { - fail "can't run to main to check for trace support" return -1 } @@ -68,7 +67,6 @@ if { [gdb_compile_pthreads "$srcdir/$subdir/$srcfile" $binfile executable $optio clean_restart ${executable} if ![runto_main] { - fail "can't run to main to check for trace support" return -1 } diff --git a/gdb/testsuite/gdb.trace/ftrace.exp b/gdb/testsuite/gdb.trace/ftrace.exp index 902d172..18ce9c7 100644 --- a/gdb/testsuite/gdb.trace/ftrace.exp +++ b/gdb/testsuite/gdb.trace/ftrace.exp @@ -36,7 +36,6 @@ if [prepare_for_testing "failed to prepare" $executable $srcfile \ } if ![runto_main] { - fail "can't run to main to check for trace support" return -1 } @@ -60,7 +59,6 @@ if { [gdb_compile "$srcdir/$subdir/$srcfile" $binfile \ clean_restart ${executable} if ![runto_main] { - fail "can't run to main for ftrace tests" return 0 } diff --git a/gdb/testsuite/gdb.trace/infotrace.exp b/gdb/testsuite/gdb.trace/infotrace.exp index 16f1897..d100e16 100644 --- a/gdb/testsuite/gdb.trace/infotrace.exp +++ b/gdb/testsuite/gdb.trace/infotrace.exp @@ -108,7 +108,6 @@ gdb_trace_setactions "collect on tracepoint 1" "1" \ "collect gdb_struct1_test" "^$" gdb_run_cmd if {[gdb_test "" "Breakpoint ${decimal}, main.*"] != 0} { - fail "can't run to main" return -1 } diff --git a/gdb/testsuite/gdb.trace/mi-trace-frame-collected.exp b/gdb/testsuite/gdb.trace/mi-trace-frame-collected.exp index eefbb4b..832f87a 100644 --- a/gdb/testsuite/gdb.trace/mi-trace-frame-collected.exp +++ b/gdb/testsuite/gdb.trace/mi-trace-frame-collected.exp @@ -27,7 +27,6 @@ if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile} {debug}] } } if ![runto_main] { - fail "can't run to main to check for trace support" return -1 } diff --git a/gdb/testsuite/gdb.trace/mi-trace-unavailable.exp b/gdb/testsuite/gdb.trace/mi-trace-unavailable.exp index 27194a1..7282454 100644 --- a/gdb/testsuite/gdb.trace/mi-trace-unavailable.exp +++ b/gdb/testsuite/gdb.trace/mi-trace-unavailable.exp @@ -22,7 +22,6 @@ if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile} {debug nopi } if ![runto_main] { - fail "can't run to main to check for trace support" return -1 } diff --git a/gdb/testsuite/gdb.trace/mi-traceframe-changed.exp b/gdb/testsuite/gdb.trace/mi-traceframe-changed.exp index d441689..e0d3135 100644 --- a/gdb/testsuite/gdb.trace/mi-traceframe-changed.exp +++ b/gdb/testsuite/gdb.trace/mi-traceframe-changed.exp @@ -107,7 +107,6 @@ if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" \ clean_restart $executable if ![runto_main] { - fail "can't run to main to check for trace support" return -1 } diff --git a/gdb/testsuite/gdb.trace/mi-tracepoint-changed.exp b/gdb/testsuite/gdb.trace/mi-tracepoint-changed.exp index 58503a3..d2e9ae4 100644 --- a/gdb/testsuite/gdb.trace/mi-tracepoint-changed.exp +++ b/gdb/testsuite/gdb.trace/mi-tracepoint-changed.exp @@ -70,7 +70,6 @@ proc test_reconnect { } { gdb_load_shlib $lib_sl1 gdb_load_shlib $lib_sl2 if ![runto_main] then { - fail "can't run to main" return 0 } # Create tracepoints on marker and main, and leave them in the @@ -251,7 +250,6 @@ gdb_load_shlib $lib_sl1 gdb_load_shlib $lib_sl2 if ![runto_main] { - fail "can't run to main to check for trace support" return -1 } diff --git a/gdb/testsuite/gdb.trace/mi-tsv-changed.exp b/gdb/testsuite/gdb.trace/mi-tsv-changed.exp index b3d01e8..577e342 100644 --- a/gdb/testsuite/gdb.trace/mi-tsv-changed.exp +++ b/gdb/testsuite/gdb.trace/mi-tsv-changed.exp @@ -71,7 +71,6 @@ proc test_create_delete_modify_tsv { } { clean_restart $testfile if ![runto_main] { - fail "can't run to main to check for trace support" return -1 } @@ -153,7 +152,6 @@ proc test_upload_tsv { } { clean_restart $testfile if ![runto_main] then { - fail "can't run to main" return 0 } @@ -239,7 +237,6 @@ proc test_upload_tsv { } { clean_restart $testfile if ![runto_main] { - fail "can't run to main to check for trace support" return -1 } diff --git a/gdb/testsuite/gdb.trace/no-attach-trace.exp b/gdb/testsuite/gdb.trace/no-attach-trace.exp index 5bd730f..552446a 100644 --- a/gdb/testsuite/gdb.trace/no-attach-trace.exp +++ b/gdb/testsuite/gdb.trace/no-attach-trace.exp @@ -43,7 +43,6 @@ gdb_test "tstart" "Target returns error code.*\." with_test_prefix "after tstart" { if ![runto_main] { - fail "can't run to main, target may have died unexpectedly" return -1 } } diff --git a/gdb/testsuite/gdb.trace/pending.exp b/gdb/testsuite/gdb.trace/pending.exp index bbff223..94a1e27 100644 --- a/gdb/testsuite/gdb.trace/pending.exp +++ b/gdb/testsuite/gdb.trace/pending.exp @@ -52,7 +52,6 @@ gdb_load_shlib $lib_sl1 gdb_load_shlib $lib_sl2 if ![runto_main] { - fail "can't run to main to check for trace support" return -1 } @@ -188,7 +187,6 @@ proc pending_tracepoint_resolved_during_trace { trace_type } \ # Start with a fresh gdb. clean_restart $executable if ![runto_main] { - fail "can't run to main" return -1 } @@ -257,7 +255,6 @@ proc pending_tracepoint_installed_during_trace { trace_type } \ # Start with a fresh gdb. clean_restart $executable if ![runto_main] { - fail "can't run to main" return -1 } @@ -331,7 +328,6 @@ proc pending_tracepoint_disconnect_during_trace { trace_type } \ # Start with a fresh gdb. clean_restart $executable if ![runto_main] { - fail "can't run to main" return -1 } @@ -379,7 +375,6 @@ proc pending_tracepoint_disconnect_after_resolved { trace_type } \ # Start with a fresh gdb. clean_restart $executable if ![runto_main] { - fail "can't run to main" return -1 } @@ -432,7 +427,6 @@ proc pending_tracepoint_with_action_resolved { trace_type } \ # Start with a fresh gdb. clean_restart $executable if ![runto_main] { - fail "can't run to main" return -1 } diff --git a/gdb/testsuite/gdb.trace/pr16508.exp b/gdb/testsuite/gdb.trace/pr16508.exp index d0ecadd..2070648 100644 --- a/gdb/testsuite/gdb.trace/pr16508.exp +++ b/gdb/testsuite/gdb.trace/pr16508.exp @@ -23,7 +23,6 @@ if [prepare_for_testing "failed to prepare for trace tests" \ } if ![runto_main] { - fail "can't run to main to check for trace support" return -1 } diff --git a/gdb/testsuite/gdb.trace/qtro.exp b/gdb/testsuite/gdb.trace/qtro.exp index 0fadfa6..b129883 100644 --- a/gdb/testsuite/gdb.trace/qtro.exp +++ b/gdb/testsuite/gdb.trace/qtro.exp @@ -27,7 +27,6 @@ if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug nopie}]} } if ![runto_main] { - fail "can't run to main to check for trace support" return -1 } diff --git a/gdb/testsuite/gdb.trace/range-stepping.exp b/gdb/testsuite/gdb.trace/range-stepping.exp index 156d862..cc3c7a8 100644 --- a/gdb/testsuite/gdb.trace/range-stepping.exp +++ b/gdb/testsuite/gdb.trace/range-stepping.exp @@ -25,7 +25,6 @@ if [prepare_for_testing "failed to prepare" $executable $srcfile \ } if ![runto_main] { - fail "can't run to main to check for trace support" return -1 } @@ -82,7 +81,6 @@ if { [gdb_compile "$srcdir/$subdir/$srcfile" $binfile \ clean_restart ${executable} if ![runto_main] { - fail "can't run to main for ftrace tests" return 0 } diff --git a/gdb/testsuite/gdb.trace/read-memory.exp b/gdb/testsuite/gdb.trace/read-memory.exp index 295784c..cad2f7d 100644 --- a/gdb/testsuite/gdb.trace/read-memory.exp +++ b/gdb/testsuite/gdb.trace/read-memory.exp @@ -22,7 +22,6 @@ if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug nopie}]} } if ![runto_main] { - fail "can't run to main to check for trace support" return -1 } @@ -39,7 +38,6 @@ proc set_tracepoint_and_collect { } { # Start with a fresh gdb. clean_restart ${testfile} if ![runto_main] { - fail "can't run to main" return -1 } gdb_breakpoint "end" qualified diff --git a/gdb/testsuite/gdb.trace/signal.exp b/gdb/testsuite/gdb.trace/signal.exp index 218c7ba..df257cd 100644 --- a/gdb/testsuite/gdb.trace/signal.exp +++ b/gdb/testsuite/gdb.trace/signal.exp @@ -40,7 +40,6 @@ if {[prepare_for_testing "failed to prepare" $testfile $srcfile debug]} { } if ![runto_main] { - fail "can't run to main to check for trace support" return -1 } @@ -67,7 +66,6 @@ if { [istarget "i\[34567\]86-*-linux*"] || [istarget "x86_64-*-linux*"] } { # Start with a fresh gdb. clean_restart ${testfile} if ![runto_main] { - fail "can't run to main" return -1 } diff --git a/gdb/testsuite/gdb.trace/status-stop.exp b/gdb/testsuite/gdb.trace/status-stop.exp index e129f01..1960b64 100644 --- a/gdb/testsuite/gdb.trace/status-stop.exp +++ b/gdb/testsuite/gdb.trace/status-stop.exp @@ -25,7 +25,6 @@ if [prepare_for_testing "failed to prepare" $executable $srcfile \ } if ![runto_main] { - fail "can't run to main to check for trace support" return -1 } @@ -44,7 +43,6 @@ proc test_tstart_tstop_tstart { } { # Start with a fresh gdb. clean_restart ${executable} if ![runto_main] { - fail "can't run to main" return -1 } @@ -71,7 +69,6 @@ proc test_tstart_tstart { } { # Start with a fresh gdb. clean_restart ${executable} if ![runto_main] { - fail "can't run to main" return -1 } @@ -98,7 +95,6 @@ proc test_buffer_full_tstart { } { # Start with a fresh gdb. clean_restart ${executable} if ![runto_main] { - fail "can't run to main" return -1 } diff --git a/gdb/testsuite/gdb.trace/strace.exp b/gdb/testsuite/gdb.trace/strace.exp index 82d62fc..1038b87 100644 --- a/gdb/testsuite/gdb.trace/strace.exp +++ b/gdb/testsuite/gdb.trace/strace.exp @@ -51,7 +51,6 @@ proc strace_remove_socket { action } { clean_restart $executable gdb_load_shlib $libipa if ![runto_main] { - fail "can't run to main" return -1 } @@ -136,7 +135,6 @@ proc strace_info_marker { } { clean_restart $executable gdb_load_shlib $libipa if ![runto_main] { - fail "can't run to main" return -1 } @@ -173,7 +171,6 @@ proc strace_probe_marker { } { clean_restart $executable gdb_load_shlib $libipa if ![runto_main] { - fail "can't run to main" return -1 } @@ -213,7 +210,6 @@ proc strace_trace_on_same_addr { type } { clean_restart $executable gdb_load_shlib $libipa if ![runto_main] { - fail "can't run to main" return -1 } @@ -317,7 +313,6 @@ proc strace_trace_on_diff_addr { } { clean_restart $executable gdb_load_shlib $libipa if ![runto_main] { - fail "can't run to main" return -1 } @@ -377,7 +372,6 @@ if { [istarget "x86_64-*-linux*"] || [istarget "i\[34567\]86-*-linux*"] } { clean_restart $executable gdb_load_shlib $libipa if ![runto_main] { - fail "can't run to main to check for trace support" return -1 } if { ![gdb_target_supports_trace] } then { diff --git a/gdb/testsuite/gdb.trace/trace-break.exp b/gdb/testsuite/gdb.trace/trace-break.exp index cf60bfa..2e55d5c 100644 --- a/gdb/testsuite/gdb.trace/trace-break.exp +++ b/gdb/testsuite/gdb.trace/trace-break.exp @@ -32,7 +32,6 @@ if [prepare_for_testing "failed to prepare" $executable $srcfile \ } if ![runto_main] { - fail "can't run to main to check for trace support" return -1 } @@ -52,7 +51,6 @@ proc break_trace_same_addr_1 { trace_type option } \ # Start with a fresh gdb. clean_restart ${executable} if ![runto_main] { - fail "can't run to main" return -1 } @@ -87,7 +85,6 @@ proc break_trace_same_addr_2 { trace_type1 trace_type2 option } \ # Start with a fresh gdb. clean_restart ${executable} if ![runto_main] { - fail "can't run to main" return -1 } @@ -126,7 +123,6 @@ proc break_trace_same_addr_3 { trace_type option } \ # Start with a fresh gdb. clean_restart ${executable} if ![runto_main] { - fail "can't run to main" return -1 } @@ -164,7 +160,6 @@ proc break_trace_same_addr_4 { trace_type option } \ # Start with a fresh gdb. clean_restart ${executable} if ![runto_main] { - fail "can't run to main" return -1 } @@ -208,7 +203,6 @@ proc break_trace_same_addr_5 { trace1 trace2 trace3 trace3_at_first_loc } \ # Start with a fresh gdb. clean_restart ${executable} if ![runto_main] { - fail "can't run to main" return -1 } @@ -282,7 +276,6 @@ proc break_trace_same_addr_6 { trace1 enable1 trace2 enable2 } \ # Start with a fresh gdb. clean_restart ${executable} if ![runto_main] { - fail "can't run to main" return -1 } @@ -371,7 +364,6 @@ if { [gdb_compile "$srcdir/$subdir/$srcfile" $binfile \ clean_restart ${executable} if ![runto_main] { - fail "can't run to main for ftrace tests" return 0 } diff --git a/gdb/testsuite/gdb.trace/trace-buffer-size.exp b/gdb/testsuite/gdb.trace/trace-buffer-size.exp index e3962fa..2b2bb42 100644 --- a/gdb/testsuite/gdb.trace/trace-buffer-size.exp +++ b/gdb/testsuite/gdb.trace/trace-buffer-size.exp @@ -23,7 +23,6 @@ if [prepare_for_testing "failed to prepare" $testfile $srcfile \ } if ![runto_main] { - fail "can't run to main to check for trace support" return -1 } diff --git a/gdb/testsuite/gdb.trace/trace-condition.exp b/gdb/testsuite/gdb.trace/trace-condition.exp index 3b23b4f..4eb376e 100644 --- a/gdb/testsuite/gdb.trace/trace-condition.exp +++ b/gdb/testsuite/gdb.trace/trace-condition.exp @@ -36,7 +36,6 @@ if [prepare_for_testing "failed to prepare" $executable $srcfile \ } if ![runto_main] { - fail "can't run to main to check for trace support" return -1 } @@ -61,7 +60,6 @@ if { [gdb_compile "$srcdir/$subdir/$srcfile" $binfile \ clean_restart ${executable} if ![runto_main] { - fail "can't run to main for ftrace tests" return 0 } @@ -76,7 +74,6 @@ proc test_tracepoints { trace_command condition num_frames { kfail_proc 0 } } { clean_restart ${executable} if ![runto_main] { - fail "can't run to main for ftrace tests" return 0 } diff --git a/gdb/testsuite/gdb.trace/trace-enable-disable.exp b/gdb/testsuite/gdb.trace/trace-enable-disable.exp index 3733cd6..4ceae1a 100644 --- a/gdb/testsuite/gdb.trace/trace-enable-disable.exp +++ b/gdb/testsuite/gdb.trace/trace-enable-disable.exp @@ -38,7 +38,6 @@ if { [gdb_compile "$srcdir/$subdir/$srcfile" $binfile executable $options] != "" clean_restart ${testfile} if ![runto_main] { - fail "can't run to main to check for trace support" return -1 } @@ -70,7 +69,6 @@ proc test_tracepoint_enable_disable { tracepoint_cmd } { set expected 0 if ![runto_main] { - fail "can't run to main." return -1 } diff --git a/gdb/testsuite/gdb.trace/trace-mt.exp b/gdb/testsuite/gdb.trace/trace-mt.exp index 1c81b2e..634c1e7 100644 --- a/gdb/testsuite/gdb.trace/trace-mt.exp +++ b/gdb/testsuite/gdb.trace/trace-mt.exp @@ -35,7 +35,6 @@ if { [gdb_compile_pthreads "$srcdir/$subdir/$srcfile" $binfile \ clean_restart ${testfile} if ![runto_main] { - fail "can't run to main to check for trace support" return -1 } @@ -55,7 +54,6 @@ proc step_over_tracepoint { trace_type } \ # Make sure inferior is running in all-stop mode. gdb_test_no_output "set non-stop 0" if ![runto_main] { - fail "can't run to main" return -1 } @@ -80,7 +78,6 @@ proc break_trace_same_addr { trace_type option } \ # Start with a fresh gdb. clean_restart ${executable} if ![runto_main] { - fail "can't run to main" return -1 } @@ -127,7 +124,6 @@ if { [gdb_compile_pthreads "$srcdir/$subdir/$srcfile" $binfile \ clean_restart ${executable} if ![runto_main] { - fail "can't run to main for ftrace tests" return 0 } diff --git a/gdb/testsuite/gdb.trace/tracefile-pseudo-reg.exp b/gdb/testsuite/gdb.trace/tracefile-pseudo-reg.exp index eafab1d..7746a80 100644 --- a/gdb/testsuite/gdb.trace/tracefile-pseudo-reg.exp +++ b/gdb/testsuite/gdb.trace/tracefile-pseudo-reg.exp @@ -27,7 +27,6 @@ if {[prepare_for_testing "failed to prepare" $testfile $srcfile \ } if ![runto_main] { - fail "can't run to main to check for trace support" return -1 } diff --git a/gdb/testsuite/gdb.trace/tspeed.exp b/gdb/testsuite/gdb.trace/tspeed.exp index 5728194..59cea40 100644 --- a/gdb/testsuite/gdb.trace/tspeed.exp +++ b/gdb/testsuite/gdb.trace/tspeed.exp @@ -36,7 +36,6 @@ if { [gdb_compile "$srcdir/$subdir/$srcfile" $binfile executable $options] != "" clean_restart ${testfile} if ![runto_main] { - fail "can't run to main to check for trace support" return -1 } diff --git a/gdb/testsuite/gdb.trace/tstatus.exp b/gdb/testsuite/gdb.trace/tstatus.exp index 69edda6..bbecfe4 100644 --- a/gdb/testsuite/gdb.trace/tstatus.exp +++ b/gdb/testsuite/gdb.trace/tstatus.exp @@ -29,7 +29,6 @@ if [prepare_for_testing "failed to prepare" $executable $srcfile \ } if ![runto_main] { - fail "can't run to main to check for trace support" return -1 } diff --git a/gdb/testsuite/gdb.trace/tsv.exp b/gdb/testsuite/gdb.trace/tsv.exp index ff49aff..210ee98 100644 --- a/gdb/testsuite/gdb.trace/tsv.exp +++ b/gdb/testsuite/gdb.trace/tsv.exp @@ -201,7 +201,6 @@ gdb_test_multiple "target ctf ${tracefile}.ctf" "" { clean_restart ${binfile} if ![runto_main] then { - fail "can't run to main" return } diff --git a/gdb/testsuite/gdb.trace/while-stepping.exp b/gdb/testsuite/gdb.trace/while-stepping.exp index db32a36..3cea488 100644 --- a/gdb/testsuite/gdb.trace/while-stepping.exp +++ b/gdb/testsuite/gdb.trace/while-stepping.exp @@ -112,7 +112,6 @@ gdb_load $binfile gdb_breakpoint "main" gdb_run_cmd if {[gdb_test "" "Breakpoint .*"] != 0} { - fail "can't run to main" return -1 } |