diff options
| author | Pedro Alves <palves@redhat.com> | 2016-03-01 17:25:56 +0000 |
|---|---|---|
| committer | Pedro Alves <palves@redhat.com> | 2016-03-01 17:25:56 +0000 |
| commit | 1e903e320352db86233e1dd2d10fd140f5d4a887 (patch) | |
| tree | be69ae8510497bf54be663fe4f1eb43a2a1b3b4b /gdb/testsuite/gdb.threads/watchpoint-fork-child.c | |
| parent | 6ccb54e2a82ca934f6d430b87ab015b7bfecc413 (diff) | |
| download | gdb-1e903e320352db86233e1dd2d10fd140f5d4a887.zip gdb-1e903e320352db86233e1dd2d10fd140f5d4a887.tar.gz gdb-1e903e320352db86233e1dd2d10fd140f5d4a887.tar.bz2 | |
Fix gdb.threads/watchpoint-fork*.c compilation
This testcase currently fails to compile on Fedora 23:
.../src/gdb/testsuite/gdb.threads/watchpoint-fork-mt.c: In function 'start':
.../src/gdb/testsuite/gdb.threads/watchpoint-fork-mt.c:70:11: warning: implicit declaration of function 'pthread_yield' [-Wimplicit-function-declaration]
i = pthread_yield ();
^
.../src/gdb/testsuite/gdb.threads/watchpoint-fork-child.c: In function 'forkoff':
.../src/gdb/testsuite/gdb.threads/watchpoint-fork-child.c:114:8: warning: implicit declaration of function 'pthread_yield' [-Wimplicit-function-declaratio
n]
i = pthread_yield ();
^
/tmp/ccUkNIsI.o: In function `start':
.../src/gdb/testsuite/gdb.threads/watchpoint-fork-mt.c:70: undefined reference to `pthread_yield'
(...)
collect2: error: ld returned 1 exit status
UNSUPPORTED: gdb.threads/watchpoint-fork.exp: child: multithreaded: Couldn't compile watchpoint-fork-child.c: unrecognized error
UNTESTED: gdb.threads/watchpoint-fork.exp: child: multithreaded: watchpoint-fork.exp
testcase .../src/gdb/testsuite/gdb.threads/watchpoint-fork.exp completed i
The glibc manual says, on _GNU_SOURCE:
"You should define these macros by using ‘#define’ preprocessor
directives at the top of your source code files. These directives must
come before any #include of a system header file."
I instead put it in the header all the .c files of the testcase must
include anyway.
gdb/testsuite/ChangeLog:
2016-03-01 Pedro Alves <palves@redhat.com>
* gdb.threads/watchpoint-fork-child.c: Include "watchpoint-fork.h"
before anything else.
* gdb.threads/watchpoint-fork-mt.c: Likewise. Don't define
_GNU_SOURCE here.
* gdb.threads/watchpoint-fork-st.c: Include "watchpoint-fork.h"
before anything else.
* gdb.threads/watchpoint-fork.h: Define _GNU_SOURCE.
Diffstat (limited to 'gdb/testsuite/gdb.threads/watchpoint-fork-child.c')
| -rw-r--r-- | gdb/testsuite/gdb.threads/watchpoint-fork-child.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/gdb/testsuite/gdb.threads/watchpoint-fork-child.c b/gdb/testsuite/gdb.threads/watchpoint-fork-child.c index 92ca0e5..b84a122 100644 --- a/gdb/testsuite/gdb.threads/watchpoint-fork-child.c +++ b/gdb/testsuite/gdb.threads/watchpoint-fork-child.c @@ -17,6 +17,8 @@ You should have received a copy of the GNU General Public License along with this program; if not, see <http://www.gnu.org/licenses/>. */ +#include "watchpoint-fork.h" + #include <string.h> #include <errno.h> #include <unistd.h> @@ -24,8 +26,6 @@ #include <signal.h> #include <stdio.h> -#include "watchpoint-fork.h" - /* `pid_t' may not be available. */ static volatile int usr1_got; |