diff options
author | Tom Tromey <tom@tromey.com> | 2023-01-22 13:38:26 -0700 |
---|---|---|
committer | Tom Tromey <tom@tromey.com> | 2023-01-25 09:02:11 -0700 |
commit | 52c0551e9ac03a54e282f9e17d3291c1c8848a7b (patch) | |
tree | 91c2286a7bbd6c070ff6a0084f45d3782bb3119a /gdb/testsuite/gdb.server | |
parent | e0a8643d2cea10858f30a8378f6cab4472dee0f9 (diff) | |
download | gdb-52c0551e9ac03a54e282f9e17d3291c1c8848a7b.zip gdb-52c0551e9ac03a54e282f9e17d3291c1c8848a7b.tar.gz gdb-52c0551e9ac03a54e282f9e17d3291c1c8848a7b.tar.bz2 |
Use require with is_remote
This changes some tests to use require with 'is_remote', rather than
an explicit test. This adds uniformity helps clean up more spots
where a test might exit early without any notification.
Diffstat (limited to 'gdb/testsuite/gdb.server')
-rw-r--r-- | gdb/testsuite/gdb.server/abspath.exp | 4 | ||||
-rw-r--r-- | gdb/testsuite/gdb.server/server-connect.exp | 4 | ||||
-rw-r--r-- | gdb/testsuite/gdb.server/server-pipe.exp | 4 |
3 files changed, 3 insertions, 9 deletions
diff --git a/gdb/testsuite/gdb.server/abspath.exp b/gdb/testsuite/gdb.server/abspath.exp index 46657c6..f58d962 100644 --- a/gdb/testsuite/gdb.server/abspath.exp +++ b/gdb/testsuite/gdb.server/abspath.exp @@ -27,9 +27,7 @@ require allow_gdbserver_tests # Because we're relying on being able to change our CWD before # executing gdbserver, we just run if we're not testing with a remote # target. -if { [is_remote target] } { - return 0 -} +require {!is_remote target} save_vars { GDBFLAGS } { # If GDB and GDBserver are both running locally, set the sysroot to avoid diff --git a/gdb/testsuite/gdb.server/server-connect.exp b/gdb/testsuite/gdb.server/server-connect.exp index 6c4c969..1f5b9a2 100644 --- a/gdb/testsuite/gdb.server/server-connect.exp +++ b/gdb/testsuite/gdb.server/server-connect.exp @@ -25,9 +25,7 @@ standard_testfile normal.c require allow_gdbserver_tests # We want to have control over where we start gdbserver. -if { [is_remote target] } { - return 0 -} +require {!is_remote target} if { [prepare_for_testing "failed to prepare" $testfile $srcfile debug] } { return -1 diff --git a/gdb/testsuite/gdb.server/server-pipe.exp b/gdb/testsuite/gdb.server/server-pipe.exp index 48b79fe..e4ad0ce 100644 --- a/gdb/testsuite/gdb.server/server-pipe.exp +++ b/gdb/testsuite/gdb.server/server-pipe.exp @@ -24,9 +24,7 @@ # This test relies on starting gdbserver using the pipe syntax. Not # sure how well this will run if part of this test is being run # elsewhere. -if { [is_remote target] || [is_remote host] } { - return 0 -} +require {!is_remote target} {!is_remote host} load_lib gdbserver-support.exp |