diff options
author | Tom de Vries <tdevries@suse.de> | 2021-11-02 09:27:48 +0100 |
---|---|---|
committer | Tom de Vries <tdevries@suse.de> | 2021-11-02 09:27:48 +0100 |
commit | c47860a4bad058631c433490c1e3ec672d613553 (patch) | |
tree | 6c63ce5298a793b220175d58ccb509ec3d007ecb /gdb/testsuite/gdb.reverse | |
parent | 317db249c7a361aa6e723fefc09116fd9cd75978 (diff) | |
download | gdb-c47860a4bad058631c433490c1e3ec672d613553.zip gdb-c47860a4bad058631c433490c1e3ec672d613553.tar.gz gdb-c47860a4bad058631c433490c1e3ec672d613553.tar.bz2 |
[gdb/testsuite] Fix stepi test-cases with unix/-m32/-fPIE/-pie
When running test-case gdb.base/step-indirect-call-thunk.exp with target board
unix/-m32/-fPIE/-pie, I run into:
...
(gdb) stepi^M
0x5655552e 22 { /* inc.1 */^M
(gdb) stepi^M
0x56555530 22 { /* inc.1 */^M
(gdb) stepi^M
0x565555f7 in __x86.get_pc_thunk.ax ()^M
(gdb) FAIL: gdb.base/step-indirect-call-thunk.exp: stepi into return thunk
...
In contrast, with unix/-m32 we have instead:
...
(gdb) stepi^M
0x08048407 22 { /* inc.1 */^M
(gdb) stepi^M
23 return x + 1; /* inc.2 */^M
(gdb) stepi^M
0x0804840c 23 return x + 1; /* inc.2 */^M
(gdb) stepi^M
24 } /* inc.3 */^M
(gdb) stepi^M
0x08048410 24 } /* inc.3 */^M
(gdb) stepi^M
0x0804848f in __x86_return_thunk ()^M
(gdb) PASS: gdb.base/step-indirect-call-thunk.exp: stepi into return thunk
...
The test-case doesn't expect to run into __x86.get_pc_thunk.ax, which is a
PIC helper function for x86_64-linux.
Fix this by insn-stepping through it.
Likewise in a few other test-cases.
Tested on x86_64-linux.
Diffstat (limited to 'gdb/testsuite/gdb.reverse')
-rw-r--r-- | gdb/testsuite/gdb.reverse/step-indirect-call-thunk.exp | 6 | ||||
-rw-r--r-- | gdb/testsuite/gdb.reverse/step-precsave.exp | 10 | ||||
-rw-r--r-- | gdb/testsuite/gdb.reverse/step-reverse.exp | 10 |
3 files changed, 24 insertions, 2 deletions
diff --git a/gdb/testsuite/gdb.reverse/step-indirect-call-thunk.exp b/gdb/testsuite/gdb.reverse/step-indirect-call-thunk.exp index 7537a01..8fe108b 100644 --- a/gdb/testsuite/gdb.reverse/step-indirect-call-thunk.exp +++ b/gdb/testsuite/gdb.reverse/step-indirect-call-thunk.exp @@ -85,7 +85,9 @@ gdb_test "reverse-next" "apply\.2.*" \ step_until "stepi" "apply\.2" "indirect_thunk" "stepi into call thunk" step_until "stepi" "indirect_thunk" "inc" \ "stepi out of call thunk into inc" -step_until "stepi" "inc" "return_thunk" "stepi into return thunk" +set alphanum_re "\[a-zA-Z0-9\]" +set pic_thunk_re "__$alphanum_re*\\.get_pc_thunk\\.$alphanum_re* \\(\\)" +step_until "stepi" "(inc|$pic_thunk_re)" "return_thunk" "stepi into return thunk" step_until "stepi" "return_thunk" "apply" \ "stepi out of return thunk back into apply" @@ -93,7 +95,7 @@ step_until "reverse-stepi" "apply" "return_thunk" \ "reverse-stepi into return thunk" step_until "reverse-stepi" "return_thunk" "inc" \ "reverse-stepi out of return thunk into inc" -step_until "reverse-stepi" "inc" "indirect_thunk" \ +step_until "reverse-stepi" "(inc|$pic_thunk_re)" "indirect_thunk" \ "reverse-stepi into call thunk" step_until "reverse-stepi" "indirect_thunk" "apply" \ "reverse-stepi out of call thunk into apply" diff --git a/gdb/testsuite/gdb.reverse/step-precsave.exp b/gdb/testsuite/gdb.reverse/step-precsave.exp index 43f6ab3..e85cdab 100644 --- a/gdb/testsuite/gdb.reverse/step-precsave.exp +++ b/gdb/testsuite/gdb.reverse/step-precsave.exp @@ -124,6 +124,8 @@ gdb_test_multiple "stepi" "$test_message" { # stepi into a function call +set alphanum_re "\[a-zA-Z0-9\]" +set pic_thunk_re "__$alphanum_re*\\.get_pc_thunk\\.$alphanum_re* \\(\\)" set test_message "stepi into function call" gdb_test_multiple "stepi" "$test_message" { -re "ARRIVED IN CALLEE.*$gdb_prompt $" { @@ -143,6 +145,10 @@ gdb_test_multiple "stepi" "$test_message" { send_gdb "stepi\n" exp_continue } + -re "$pic_thunk_re.*$gdb_prompt $" { + send_gdb "stepi\n" + exp_continue + } } # stepi thru return of a function call @@ -216,6 +222,10 @@ gdb_test_multiple "stepi" "$test_message" { send_gdb "stepi\n" exp_continue } + -re "$pic_thunk_re.*$gdb_prompt $" { + send_gdb "stepi\n" + exp_continue + } -re "${hex} in main .*:$stepi_location.*STEPI TEST.*$gdb_prompt $" { send_gdb "stepi\n" exp_continue diff --git a/gdb/testsuite/gdb.reverse/step-reverse.exp b/gdb/testsuite/gdb.reverse/step-reverse.exp index 335ccfb..32c18fa 100644 --- a/gdb/testsuite/gdb.reverse/step-reverse.exp +++ b/gdb/testsuite/gdb.reverse/step-reverse.exp @@ -87,6 +87,8 @@ gdb_test_multiple "stepi" "$test_message" { # stepi into a function call +set alphanum_re "\[a-zA-Z0-9\]" +set pic_thunk_re "__$alphanum_re*\\.get_pc_thunk\\.$alphanum_re* \\(\\)" set test_message "stepi into function call" gdb_test_multiple "stepi" "$test_message" { -re "ARRIVED IN CALLEE.*$gdb_prompt $" { @@ -106,6 +108,10 @@ gdb_test_multiple "stepi" "$test_message" { send_gdb "stepi\n" exp_continue } + -re "$pic_thunk_re.*$gdb_prompt $" { + send_gdb "stepi\n" + exp_continue + } } # stepi thru return of a function call @@ -179,6 +185,10 @@ gdb_test_multiple "stepi" "$test_message" { send_gdb "stepi\n" exp_continue } + -re "$pic_thunk_re.*$gdb_prompt $" { + send_gdb "stepi\n" + exp_continue + } -re "${hex} in main .*:$stepi_location.*STEPI TEST.*$gdb_prompt $" { send_gdb "stepi\n" exp_continue |