diff options
| author | Lancelot SIX <lsix@lancelotsix.com> | 2021-06-07 23:14:55 +0100 |
|---|---|---|
| committer | Lancelot SIX <lsix@lancelotsix.com> | 2021-06-08 23:49:05 +0100 |
| commit | f9e59d060fbdad57f8d927cf51eade0d46b47e12 (patch) | |
| tree | 1648300094500bb1e5c11d84c92e54fe770902af /gdb/testsuite/gdb.python/py-frame-args.py | |
| parent | 122373f7f25946cfc51de9e19ba1d173195f9910 (diff) | |
| download | gdb-f9e59d060fbdad57f8d927cf51eade0d46b47e12.zip gdb-f9e59d060fbdad57f8d927cf51eade0d46b47e12.tar.gz gdb-f9e59d060fbdad57f8d927cf51eade0d46b47e12.tar.bz2 | |
Use is/is not to check for None in python code.
While reviewing a patch sent to the mailing list, I noticed there are few
places where python code checks if a variable is 'None' or not by using the
comparison operators '==' and '!='. PEP8[1], which is used as coding standard
in GDBÂ coding standards, recommends using 'is' / 'is not' when comparing to a
singleton such as 'None'.
This patch proposes to change the instances of '== None' by 'is None' and
'!= None' by 'is not None'.
[1] https://www.python.org/dev/peps/pep-0008/
gdb/doc/ChangeLog:
* python.texi (Writing a Pretty-Printer): Use 'is None' instead of
'== None'.
gdb/ChangeLog:
* python/lib/gdb/FrameDecorator.py (FrameDecorator): Use 'is None' instead of
'== None'.
(FrameVars): Use 'is not None' instead of '!= None'.
* python/lib/gdb/command/frame_filters.py (SetFrameFilterPriority): Use 'is None'
instead of '== None' and 'is not None' instead of '!= None'.
gdb/testsuite/ChangeLog:
* gdb.base/premature-dummy-frame-removal.py (TestUnwinder): Use
'is None' instead of '== None' and 'is not None' instead of
'!= None'.
* gdb.python/py-frame-args.py (lookup_function): Same.
* gdb.python/py-framefilter-invalidarg.py (Reverse_Function): Same.
* gdb.python/py-framefilter.py (Reverse_Function): Same.
* gdb.python/py-nested-maps.py (lookup_function): Same.
* gdb.python/py-objfile-script-gdb.py (lookup_function): Same.
* gdb.python/py-prettyprint.py (lookup_function): Same.
* gdb.python/py-section-script.py (lookup_function): Same.
* gdb.python/py-unwind-inline.py (dummy_unwinder): Same.
* gdb.python/python.exp: Same.
* gdb.rust/pp.py (lookup_function): Same.
Diffstat (limited to 'gdb/testsuite/gdb.python/py-frame-args.py')
| -rw-r--r-- | gdb/testsuite/gdb.python/py-frame-args.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/gdb/testsuite/gdb.python/py-frame-args.py b/gdb/testsuite/gdb.python/py-frame-args.py index 32d7204..59dd14d 100644 --- a/gdb/testsuite/gdb.python/py-frame-args.py +++ b/gdb/testsuite/gdb.python/py-frame-args.py @@ -53,7 +53,7 @@ def lookup_function(val): # Get the type name. typename = type.tag - if typename == None: + if typename is None: return None # Iterate over local dictionary of types to determine |