diff options
author | Tom de Vries <tdevries@suse.de> | 2020-07-17 17:33:18 +0200 |
---|---|---|
committer | Tom de Vries <tdevries@suse.de> | 2020-07-17 17:33:18 +0200 |
commit | 33176ea7d7234e7e301301cd72d88abc7ab4cb2f (patch) | |
tree | 9547e25a4c170d3d3b128c7e57ed5dc9f72ca0da /gdb/testsuite/gdb.base/valgrind-infcall-2.exp | |
parent | f80c8ec423f006eff316d3df633f95439d7dbc7a (diff) | |
download | gdb-33176ea7d7234e7e301301cd72d88abc7ab4cb2f.zip gdb-33176ea7d7234e7e301301cd72d88abc7ab4cb2f.tar.gz gdb-33176ea7d7234e7e301301cd72d88abc7ab4cb2f.tar.bz2 |
[gdb/testsuite] Add gdb.base/valgrind-infcall-2.exp
In commit ee3c5f8968 "Fix GDB crash when registers cannot be modified", we
fix a GDB crash:
...
$ valgrind /usr/bin/sleep 10000
==31595== Memcheck, a memory error detector
==31595== Command: /usr/bin/sleep 10000
==31595==
$ gdb /usr/bin/sleep
(gdb) target remote | vgdb --pid=31595
Remote debugging using | vgdb --pid=31595
...
$hex in __GI___nanosleep () at nanosleep.c:27
27 return SYSCALL_CANCEL (nanosleep, requested_time, remaining);
(gdb) p printf ("bla")
terminate called after throwing an instance of 'gdb_exception_error'
Aborted (core dumped)
...
This patch adds a test-case for it.
Unfortunately, I was not able to trigger the error condition using a regular
vgdb_start, so I've added a parameter active_at_startup, and when set to 0
this causes valgrind to be started without --vgdb-error=0.
Tested on x86_64-linux.
Tested with the commit mentioned above reverted, resulting in:
...
(gdb) p printf ("bla")^M
terminate called after throwing an instance of 'gdb_exception_error'^M
ERROR: GDB process no longer exists
GDB process exited with wait status 6152 exp10 0 0 CHILDKILLED SIGABRT SIGABRT
UNRESOLVED: gdb.base/valgrind-infcall-2.exp: do printf
...
gdb/testsuite/ChangeLog:
2020-07-17 Tom de Vries <tdevries@suse.de>
* gdb.base/valgrind-infcall-2.c: New test.
* gdb.base/valgrind-infcall-2.exp: New file.
* lib/valgrind.exp (vgdb_start): Add and handle active_at_startup.
Diffstat (limited to 'gdb/testsuite/gdb.base/valgrind-infcall-2.exp')
-rw-r--r-- | gdb/testsuite/gdb.base/valgrind-infcall-2.exp | 75 |
1 files changed, 75 insertions, 0 deletions
diff --git a/gdb/testsuite/gdb.base/valgrind-infcall-2.exp b/gdb/testsuite/gdb.base/valgrind-infcall-2.exp new file mode 100644 index 0000000..a3983f7 --- /dev/null +++ b/gdb/testsuite/gdb.base/valgrind-infcall-2.exp @@ -0,0 +1,75 @@ +# Copyright 2020 Free Software Foundation, Inc. + +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see <http://www.gnu.org/licenses/>. + +# This test-case tests the scenario for the crash fixed by commit ee3c5f8968 +# "Fix GDB crash when registers cannot be modified": +# $ valgrind /usr/bin/sleep 10000 +# ==31595== Memcheck, a memory error detector +# ==31595== Command: /usr/bin/sleep 10000 +# ==31595== +# $ gdb /usr/bin/sleep +# (gdb) target remote | vgdb --pid=31595 +# Remote debugging using | vgdb --pid=31595 +# ... +# $hex in __GI___nanosleep () at nanosleep.c:27 +# 27 return SYSCALL_CANCEL (nanosleep, requested_time, remaining); +# (gdb) p printf ("bla") +# terminate called after throwing an instance of 'gdb_exception_error' +# Aborted (core dumped) + +load_lib valgrind.exp + +if [is_remote target] { + # The test always runs locally. + return 0 +} + +standard_testfile .c +if {[build_executable $testfile.exp $testfile $srcfile {debug}] == -1} { + return -1 +} + +set active_at_startup 0 +if { [vgdb_start $active_at_startup] == -1 } { + return -1 +} + +# Determine whether we're at nanosleep. +gdb_test_multiple "bt 1" "do printf" { + -re -wrap "nanosleep.*" { + # If gdb doesn't crash, we get something like: + # (gdb) p printf ("bla") + # Could not write register "rdi"; remote failure reply 'E. + # ERROR changing register rdi regno 5 + # gdb commands changing registers (pc, sp, ...) (e.g. 'jump', + # set pc, calling from gdb a function in the debugged process, ...) + # can only be accepted if the thread is VgTs_Runnable or VgTs_Yielding + # state + # Thread status is VgTs_WaitSys + # ' + # (gdb) + gdb_test "p printf (\"bla\")" \ + "can only be accepted if the thread is .*" \ + $gdb_test_name + } + -re -wrap "" { + # For some reason the error condition does not trigger if we're not + # at nanosleep at the point that we're connecting to vgdb. See also + # comment at "exec sleep 1" in vgdb_start. + unsupported $gdb_test_name + } +} + +vgdb_stop |