diff options
author | Andreas Arnez <arnez@linux.vnet.ibm.com> | 2016-09-09 19:59:53 +0200 |
---|---|---|
committer | Andreas Arnez <arnez@linux.vnet.ibm.com> | 2016-09-09 19:59:53 +0200 |
commit | e1b2624a08fae1f669d879946d5041945b4dc248 (patch) | |
tree | 2b3634606789cdb6b21fd1a0fe5e0e6b666f9a82 /gdb/testsuite/gdb.base/gnu-ifunc.c | |
parent | 3569342c148dd1cb4b2e1bdafe64a9e3a3701813 (diff) | |
download | gdb-e1b2624a08fae1f669d879946d5041945b4dc248.zip gdb-e1b2624a08fae1f669d879946d5041945b4dc248.tar.gz gdb-e1b2624a08fae1f669d879946d5041945b4dc248.tar.bz2 |
Pass HWCAP to ifunc resolver
On various GNU Elf architectures, including AArch64, ARM, s390/s390x,
ppc32/64, and sparc32/64, the dynamic loader passes HWCAP as a parameter
to each ifunc resolver. Currently there is an open glibc Bugzilla that
requests this to be generalized to all architectures:
https://sourceware.org/bugzilla/show_bug.cgi?id=19766
And various ifunc resolvers already rely on receiving HWCAP. Currently
GDB always calls an ifunc resolver without any arguments; thus the
resolver may receive garbage, and based on that, the resolver may decide
to return a function that is not suited for the given platform.
This patch always passes HWCAP to ifunc resolvers, even on systems where
the dynamic loader currently behaves otherwise. The rationale is
that (1) the dynamic loader may get adjusted on those systems as well in
the future; (2) passing an unused argument should not cause a problem
with existing resolvers; and (3) the logic is much simpler without such
a distinction.
gdb/ChangeLog:
* elfread.c (auxv.h): New include.
(elf_gnu_ifunc_resolve_addr): Pass HWCAP to ifunc resolver.
gdb/testsuite/ChangeLog:
* gdb.base/gnu-ifunc-lib.c (resolver_hwcap): New external
variable declaration.
(gnu_ifunc): Add parameter hwcap. Store it in resolver_hwcap.
* gdb.base/gnu-ifunc.c (resolver_hwcap): New global variable.
* gdb.base/gnu-ifunc.exp: Add test to verify that the resolver
received HWCAP as its argument.
Diffstat (limited to 'gdb/testsuite/gdb.base/gnu-ifunc.c')
-rw-r--r-- | gdb/testsuite/gdb.base/gnu-ifunc.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/gdb/testsuite/gdb.base/gnu-ifunc.c b/gdb/testsuite/gdb.base/gnu-ifunc.c index c68866e..77dea30 100644 --- a/gdb/testsuite/gdb.base/gnu-ifunc.c +++ b/gdb/testsuite/gdb.base/gnu-ifunc.c @@ -35,6 +35,10 @@ final (int arg) volatile int gnu_ifunc_initialized; +/* This stores the argument received by the ifunc resolver. */ + +volatile unsigned long resolver_hwcap = -1; + static void gnu_ifunc_pre (void) { |