diff options
author | Tom de Vries <tdevries@suse.de> | 2024-09-04 15:37:28 +0200 |
---|---|---|
committer | Tom de Vries <tdevries@suse.de> | 2024-09-04 15:37:28 +0200 |
commit | be3a561eca45104075abfe0fb4251be2b1985c8a (patch) | |
tree | afb2e3de539930160b34c3be9ea5b516f8484f1e /gdb/testsuite/gdb.arch | |
parent | 31ed3a9d691493486f6e32357d89a55229dbdc0a (diff) | |
download | gdb-be3a561eca45104075abfe0fb4251be2b1985c8a.zip gdb-be3a561eca45104075abfe0fb4251be2b1985c8a.tar.gz gdb-be3a561eca45104075abfe0fb4251be2b1985c8a.tar.bz2 |
[gdb/testsuite] Fix gdb.arch/riscv-tdesc-regs.exp
On riscv64-linux, with test-case gdb.arch/riscv-tdesc-regs.exp I get:
...
(gdb) info registers fflags^M
fflags 0x0 NV:0 DZ:0 OF:0 UF:0 NX:0^M
(gdb) FAIL: gdb.arch/riscv-tdesc-regs.exp: info registers fflags
info registers frm^M
frm 0x0 FRM:0 [RNE (round to nearest; ties to even)]^M
(gdb) FAIL: gdb.arch/riscv-tdesc-regs.exp: info registers frm
...
The FAILs are produced by:
...
foreach reg {fflags frm} {
gdb_test_multiple "info registers $reg" "" {
-re "^info registers $reg\r\n" {
exp_continue
}
-wrap -re "^Invalid register `$reg`" {
fail $gdb_test_name
}
-wrap -re "^$reg\\s+\[^\r\n\]+" {
pass $gdb_test_name
}
}
}
...
The first clause is meant to consume the command.
The '^' char was updated to mean "consume command", so that clause no longer
works since it now attempts to consume the command twice.
Also, it's unnecessary because the following clauses start with ^.
Then, the second clause is unnecessary because there's a default clause
producing the FAIL.
Fix this by simplifying to:
...
foreach reg {fflags frm} {
gdb_test "info registers $reg" "^$reg\\s+\[^\r\n\]+"
}
...
Tested on riscv64-linux.
Approved-By: Andrew Burgess <aburgess@redhat.com>
Diffstat (limited to 'gdb/testsuite/gdb.arch')
-rw-r--r-- | gdb/testsuite/gdb.arch/riscv-tdesc-regs.exp | 14 |
1 files changed, 1 insertions, 13 deletions
diff --git a/gdb/testsuite/gdb.arch/riscv-tdesc-regs.exp b/gdb/testsuite/gdb.arch/riscv-tdesc-regs.exp index bd4ba38..58859d1 100644 --- a/gdb/testsuite/gdb.arch/riscv-tdesc-regs.exp +++ b/gdb/testsuite/gdb.arch/riscv-tdesc-regs.exp @@ -156,17 +156,5 @@ gdb_test_no_output "set tdesc filename $remote_file" \ "load the target description that lacks fflags and frm" foreach reg {fflags frm} { - gdb_test_multiple "info registers $reg" "" { - -re "^info registers $reg\r\n" { - exp_continue - } - - -wrap -re "^Invalid register `$reg`" { - fail $gdb_test_name - } - - -wrap -re "^$reg\\s+\[^\r\n\]+" { - pass $gdb_test_name - } - } + gdb_test "info registers $reg" "^$reg\\s+\[^\r\n\]+" } |