diff options
author | Pedro Alves <palves@redhat.com> | 2017-10-24 10:43:35 +0100 |
---|---|---|
committer | Pedro Alves <palves@redhat.com> | 2017-10-24 10:54:56 +0100 |
commit | 1f75a6516a4b480b5521dfb4e1a0721887ab5cdc (patch) | |
tree | 6dd8a5f6ecf49ae947e52fd0c3cf5c327c11e234 /gdb/testsuite/ChangeLog | |
parent | 779990d9f0a169215b3619a8a1cd120550320793 (diff) | |
download | gdb-1f75a6516a4b480b5521dfb4e1a0721887ab5cdc.zip gdb-1f75a6516a4b480b5521dfb4e1a0721887ab5cdc.tar.gz gdb-1f75a6516a4b480b5521dfb4e1a0721887ab5cdc.tar.bz2 |
Drop /proc/PID/status polling from gdb.threads/attach-into-signal.exp
I noticed that the 'with_test_prefix "stoppedtry $stoppedtry"' prefix
in this testcase is unnecessary, because inside that block there are
no pass/fail calls. In fact the block includes a comment saying:
# No PASS message as we may be looping in multiple
# attempts.
but looking deeper at this I noticed a few odd things with this code
block:
1. This code is assuming that the second line in the /proc/PID/status
files is the "State:" line, which may have been true when this was
originally written, but is not true on my machine at least (Linux
4.8.13).
$ cat /proc/self/status
Name: cat
Umask: 0002
State: R (running)
So nowadays, that 'string match "*(stopped)*"' is running against
the "Umask:" line and thus always returns false, meaning the loop
always breaks on $stoppedtry == 0.
2. The loop seems to be waiting for the process to become "(stopped)",
but if so then that 'if {![string match]}' check is reversed, it
should be checking 'if {[string match]}' instead, because "string
match" returns true if the string matches, not 0.
3. But if we fixed all that, we'd still run into the simple fact that
nothing is actually stopping the test's inferior process before GDB
attaches... The top of the testcase says:
# This test was created by modifying attach-stopped.exp.
... and attach-stopped.exp does have:
# Stop the program
remote_exec build "kill -s STOP ${testpid}"
but then attach-stopped.exp doesn't have an equivalent
/proc/PID/status poll loop... (Maybe it could.)
So remove this whole loop as useless.
gdb/testsuite/ChangeLog:
2017-10-24 Pedro Alves <palves@redhat.com>
* gdb.threads/attach-into-signal.exp: Remove whole "stoppedtry"
loop.
Diffstat (limited to 'gdb/testsuite/ChangeLog')
-rw-r--r-- | gdb/testsuite/ChangeLog | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 0038a0c..25dcd06 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,5 +1,10 @@ 2017-10-24 Pedro Alves <palves@redhat.com> + * gdb.threads/attach-into-signal.exp: Remove whole "stoppedtry" + loop. + +2017-10-24 Pedro Alves <palves@redhat.com> + * gdb.threads/attach-into-signal.exp (corefunc): Remove "attach $attempt" and "stoppedtry $stoppedtry" test prefixes. |