aboutsummaryrefslogtreecommitdiff
path: root/gdb/target.h
diff options
context:
space:
mode:
authorYao Qi <yao@codesourcery.com>2013-12-16 21:13:36 +0800
committerYao Qi <yao@codesourcery.com>2014-02-23 11:44:28 +0800
commitf73023dd06cb038bdb212d05064b03e38fd7d9db (patch)
tree86bd9b25537063fc07cfda3bce67acc0bd42f9f6 /gdb/target.h
parent5a2eb0ef7f9b879c2bbe7b18183353e1d59c93c7 (diff)
downloadgdb-f73023dd06cb038bdb212d05064b03e38fd7d9db.zip
gdb-f73023dd06cb038bdb212d05064b03e38fd7d9db.tar.gz
gdb-f73023dd06cb038bdb212d05064b03e38fd7d9db.tar.bz2
Revert previous tweaks
As we migrate to the new to_xfer_partial interface, some of previous tweaks become unnecessary, we don't have to check traceframe is selected in each target implementation, so this patch below is reverted. [PATCH] Send qXfer:traceframe-info:read when traceframe is selected. https://sourceware.org/ml/gdb-patches/2013-10/msg00752.html Third, to_traceframe_info is only called when traceframe is selected, that means it is only called when target is remote, tfile or ctf, so this patch can be partially reverted, https://sourceware.org/ml/gdb-patches/2013-04/msg00000.html gdb: 2014-02-23 Yao Qi <yao@codesourcery.com> Revert two patches: 2013-10-25 Yao Qi <yao@codesourcery.com> * remote.c (remote_traceframe_info): Return early if traceframe is not selected. 2013-07-19 Yao Qi <yao@codesourcery.com> * target.c (update_current_target): Change the default action of 'to_traceframe_info' from tcomplain to return_zero. * target.h (struct target_ops) <to_traceframe_info>: Add more comments.
Diffstat (limited to 'gdb/target.h')
-rw-r--r--gdb/target.h17
1 files changed, 4 insertions, 13 deletions
diff --git a/gdb/target.h b/gdb/target.h
index 2cc3c13..6cc1337 100644
--- a/gdb/target.h
+++ b/gdb/target.h
@@ -974,20 +974,11 @@ struct target_ops
TARGET_DEFAULT_NORETURN (tcomplain ());
/* Return a traceframe info object describing the current
- traceframe's contents. If the target doesn't support
- traceframe info, return NULL. If the current traceframe is not
- selected (the current traceframe number is -1), the target can
- choose to return either NULL or an empty traceframe info. If
- NULL is returned, for example in remote target, GDB will read
- from the live inferior. If an empty traceframe info is
- returned, for example in tfile target, which means the
- traceframe info is available, but the requested memory is not
- available in it. GDB will try to see if the requested memory
- is available in the read-only sections. This method should not
- cache data; higher layers take care of caching, invalidating,
- and re-fetching when necessary. */
+ traceframe's contents. This method should not cache data;
+ higher layers take care of caching, invalidating, and
+ re-fetching when necessary. */
struct traceframe_info *(*to_traceframe_info) (struct target_ops *)
- TARGET_DEFAULT_RETURN (NULL);
+ TARGET_DEFAULT_RETURN (tcomplain ());
/* Ask the target to use or not to use agent according to USE. Return 1
successful, 0 otherwise. */